Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 302973003: Removed v8::Isolate::GetCurrent() and fixed toV8 with empty context. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Removed v8::Isolate::GetCurrent() and fixed toV8 with empty context. BUG=369451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175279

Patch Set 1 #

Total comments: 3

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M Source/web/WebArrayBufferConverter.cpp View 2 chunks +15 lines, -0 lines 0 comments Download
M public/web/WebArrayBufferConverter.h View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tasak
Would you review this CL?
6 years, 6 months ago (2014-05-29 10:33:39 UTC) #1
haraken
LGTM https://codereview.chromium.org/302973003/diff/1/public/web/WebArrayBufferConverter.h File public/web/WebArrayBufferConverter.h (right): https://codereview.chromium.org/302973003/diff/1/public/web/WebArrayBufferConverter.h#newcode48 public/web/WebArrayBufferConverter.h:48: BLINK_EXPORT static WebArrayBuffer* createFromV8Value(v8::Handle<v8::Value>); Shall we add a ...
6 years, 6 months ago (2014-05-29 10:38:19 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/302973003/diff/1/public/web/WebArrayBufferConverter.h File public/web/WebArrayBufferConverter.h (right): https://codereview.chromium.org/302973003/diff/1/public/web/WebArrayBufferConverter.h#newcode48 public/web/WebArrayBufferConverter.h:48: BLINK_EXPORT static WebArrayBuffer* createFromV8Value(v8::Handle<v8::Value>); On 2014/05/29 10:38:19, haraken ...
6 years, 6 months ago (2014-06-02 07:33:59 UTC) #3
tasak
Thank you for reviewing. https://codereview.chromium.org/302973003/diff/1/public/web/WebArrayBufferConverter.h File public/web/WebArrayBufferConverter.h (right): https://codereview.chromium.org/302973003/diff/1/public/web/WebArrayBufferConverter.h#newcode48 public/web/WebArrayBufferConverter.h:48: BLINK_EXPORT static WebArrayBuffer* createFromV8Value(v8::Handle<v8::Value>); On ...
6 years, 6 months ago (2014-06-02 10:36:44 UTC) #4
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-02 10:36:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/302973003/20001
6 years, 6 months ago (2014-06-02 10:37:33 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-02 11:49:33 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 12:24:10 UTC) #8
Message was sent while issue was closed. 
Change committed as 175279

Powered by Google App Engine
This is Rietveld 408576698