Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: public/web/WebArrayBufferConverter.h

Issue 302973003: Removed v8::Isolate::GetCurrent() and fixed toV8 with empty context. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebArrayBufferConverter.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebArrayBufferConverter.h
diff --git a/public/web/WebArrayBufferConverter.h b/public/web/WebArrayBufferConverter.h
index 1c5bde03179cb27f90b37bd11e78698ce884d74b..5dc0d010c655ca3dd2d4246b9ffaf39b77887dda 100644
--- a/public/web/WebArrayBufferConverter.h
+++ b/public/web/WebArrayBufferConverter.h
@@ -34,6 +34,8 @@
#include "public/platform/WebArrayBuffer.h"
namespace v8 {
+class Isolate;
+class Object;
class Value;
template <class T> class Handle;
}
@@ -42,8 +44,12 @@ namespace blink {
class WebArrayBufferConverter {
public:
+ // FIXME: remove these two APIs which doesn't take either context or
+ // isolate as their parameters after the embedder side is fixed.
BLINK_EXPORT static v8::Handle<v8::Value> toV8Value(WebArrayBuffer*);
BLINK_EXPORT static WebArrayBuffer* createFromV8Value(v8::Handle<v8::Value>);
+ BLINK_EXPORT static v8::Handle<v8::Value> toV8Value(WebArrayBuffer*, v8::Handle<v8::Object>, v8::Isolate*);
+ BLINK_EXPORT static WebArrayBuffer* createFromV8Value(v8::Handle<v8::Value>, v8::Isolate*);
};
} // namespace blink
« no previous file with comments | « Source/web/WebArrayBufferConverter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698