Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: Source/web/WebArrayBufferConverter.cpp

Issue 302973003: Removed v8::Isolate::GetCurrent() and fixed toV8 with empty context. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | public/web/WebArrayBufferConverter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 39
40 namespace blink { 40 namespace blink {
41 41
42 v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer) 42 v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer)
43 { 43 {
44 if (!buffer) 44 if (!buffer)
45 return v8::Handle<v8::Value>(); 45 return v8::Handle<v8::Value>();
46 return toV8(*buffer, v8::Handle<v8::Object>(), v8::Isolate::GetCurrent()); 46 return toV8(*buffer, v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());
47 } 47 }
48 48
49 v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
50 {
51 if (!buffer)
52 return v8::Handle<v8::Value>();
53 return toV8(*buffer, creationContext, isolate);
54 }
55
49 WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value) 56 WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value)
50 { 57 {
51 if (!V8ArrayBuffer::hasInstance(value, v8::Isolate::GetCurrent())) 58 if (!V8ArrayBuffer::hasInstance(value, v8::Isolate::GetCurrent()))
52 return 0; 59 return 0;
53 WTF::ArrayBuffer* buffer = V8ArrayBuffer::toNative(value->ToObject()); 60 WTF::ArrayBuffer* buffer = V8ArrayBuffer::toNative(value->ToObject());
54 return new WebArrayBuffer(buffer); 61 return new WebArrayBuffer(buffer);
55 } 62 }
56 63
64 WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value, v8::Isolate* isolate)
65 {
66 if (!V8ArrayBuffer::hasInstance(value, isolate))
67 return 0;
68 WTF::ArrayBuffer* buffer = V8ArrayBuffer::toNative(value->ToObject());
69 return new WebArrayBuffer(buffer);
70 }
71
57 } // namespace blink 72 } // namespace blink
58 73
OLDNEW
« no previous file with comments | « no previous file | public/web/WebArrayBufferConverter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698