Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: Source/web/WebArrayBufferConverter.cpp

Issue 302973003: Removed v8::Isolate::GetCurrent() and fixed toV8 with empty context. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | public/web/WebArrayBufferConverter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebArrayBufferConverter.cpp
diff --git a/Source/web/WebArrayBufferConverter.cpp b/Source/web/WebArrayBufferConverter.cpp
index 32d9c41df189466cd986de122f9248c0b1cef351..a0241a59558169bb38522e53dcaf0b2a7bf79af8 100644
--- a/Source/web/WebArrayBufferConverter.cpp
+++ b/Source/web/WebArrayBufferConverter.cpp
@@ -46,6 +46,13 @@ v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer)
return toV8(*buffer, v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());
}
+v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+ if (!buffer)
+ return v8::Handle<v8::Value>();
+ return toV8(*buffer, creationContext, isolate);
+}
+
WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value)
{
if (!V8ArrayBuffer::hasInstance(value, v8::Isolate::GetCurrent()))
@@ -54,5 +61,13 @@ WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value>
return new WebArrayBuffer(buffer);
}
+WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value, v8::Isolate* isolate)
+{
+ if (!V8ArrayBuffer::hasInstance(value, isolate))
+ return 0;
+ WTF::ArrayBuffer* buffer = V8ArrayBuffer::toNative(value->ToObject());
+ return new WebArrayBuffer(buffer);
+}
+
} // namespace blink
« no previous file with comments | « no previous file | public/web/WebArrayBufferConverter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698