Issue 302123002: Enable zero length source size in sizes attribute

Issue 302123002: Enable zero length source size in sizes attribute (Closed)

Created:
6 years, 6 months ago by Yoav Weiss

Modified:
6 years, 6 months ago

Reviewers:
esprehn, eseidel

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, simonp, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Enable zero length source size in sizes attribute According to the spec, zero-length source-size is permitted. For some reason, current implementation treats them as invalid. This CL fixes that. BUG=379088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175302

Patch Set 1 #

Patch Set 2 : Break out of length calc early for empty length #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
M	Source/core/css/parser/SizesAttributeParser.h	View		2 chunks	+2 lines, -0 lines	1 comment	Download
M	Source/core/css/parser/SizesAttributeParser.cpp	View	1	4 chunks	+7 lines, -1 line	0 comments	Download
M	Source/core/css/parser/SizesAttributeParserTest.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/302123002/diff/20001/Source/core/css/parser/SizesAttributeParser.h File Source/core/css/parser/SizesAttributeParser.h (right): https://codereview.chromium.org/302123002/diff/20001/Source/core/css/parser/SizesAttributeParser.h#newcode24 Source/core/css/parser/SizesAttributeParser.h:24: , m_lengthWasSet(false) Entertained that Chris Dumez was just ...

6 years, 6 months ago (2014-06-02 16:24:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/302123002/20001

6 years, 6 months ago (2014-06-02 16:59:01 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...

6 years, 6 months ago (2014-06-02 17:21:16 UTC) #5

Message was sent while issue was closed.

Change committed as 175302

Expand Messages | Collapse Messages