Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: Source/core/css/parser/SizesAttributeParser.h

Issue 302123002: Enable zero length source size in sizes attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Break out of length calc early for empty length Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/css/parser/SizesAttributeParser.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SizesAttributeParser_h 5 #ifndef SizesAttributeParser_h
6 #define SizesAttributeParser_h 6 #define SizesAttributeParser_h
7 7
8 #include "core/css/MediaValues.h" 8 #include "core/css/MediaValues.h"
9 #include "core/css/parser/MediaQueryParser.h" 9 #include "core/css/parser/MediaQueryParser.h"
10 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
11 #include "wtf/text/WTFString.h" 11 #include "wtf/text/WTFString.h"
12 12
13 namespace WebCore { 13 namespace WebCore {
14 14
15 class SizesAttributeParser { 15 class SizesAttributeParser {
16 STACK_ALLOCATED(); 16 STACK_ALLOCATED();
17 public: 17 public:
18 static unsigned findEffectiveSize(const String& attribute, PassRefPtr<MediaV alues>); 18 static unsigned findEffectiveSize(const String& attribute, PassRefPtr<MediaV alues>);
19 19
20 private: 20 private:
21 SizesAttributeParser(PassRefPtr<MediaValues> mediaValues) 21 SizesAttributeParser(PassRefPtr<MediaValues> mediaValues)
22 : m_mediaValues(mediaValues) 22 : m_mediaValues(mediaValues)
23 , m_length(0) 23 , m_length(0)
24 , m_lengthWasSet(false)
eseidel 2014/06/02 16:24:38 Entertained that Chris Dumez was just making one o
24 { 25 {
25 } 26 }
26 27
27 bool parse(Vector<MediaQueryToken>& tokens); 28 bool parse(Vector<MediaQueryToken>& tokens);
28 bool parseMediaConditionAndLength(MediaQueryTokenIterator startToken, MediaQ ueryTokenIterator endToken); 29 bool parseMediaConditionAndLength(MediaQueryTokenIterator startToken, MediaQ ueryTokenIterator endToken);
29 unsigned effectiveSize(); 30 unsigned effectiveSize();
30 bool calculateLengthInPixels(MediaQueryTokenIterator startToken, MediaQueryT okenIterator endToken, unsigned& result); 31 bool calculateLengthInPixels(MediaQueryTokenIterator startToken, MediaQueryT okenIterator endToken, unsigned& result);
31 bool mediaConditionMatches(PassRefPtrWillBeRawPtr<MediaQuerySet> mediaCondit ion); 32 bool mediaConditionMatches(PassRefPtrWillBeRawPtr<MediaQuerySet> mediaCondit ion);
32 unsigned effectiveSizeDefaultValue(); 33 unsigned effectiveSizeDefaultValue();
33 34
34 RefPtrWillBeMember<MediaQuerySet> m_mediaCondition; 35 RefPtrWillBeMember<MediaQuerySet> m_mediaCondition;
35 RefPtr<MediaValues> m_mediaValues; 36 RefPtr<MediaValues> m_mediaValues;
36 unsigned m_length; 37 unsigned m_length;
38 bool m_lengthWasSet;
37 }; 39 };
38 40
39 } // namespace 41 } // namespace
40 42
41 #endif 43 #endif
42 44
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/parser/SizesAttributeParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698