Source/core/css/parser/SizesAttributeParserTest.cpp - Issue 302123002: Enable zero length source size in sizes attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/SizesAttributeParserTest.cpp

Issue 302123002: Enable zero length source size in sizes attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Break out of length calc early for empty length Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/SizesAttributeParserTest.cpp

diff --git a/Source/core/css/parser/SizesAttributeParserTest.cpp b/Source/core/css/parser/SizesAttributeParserTest.cpp

index e8765b07777310aad7f4f6b4e1588a75f3f63de2..bd60c2990f1b06579b837e00d8b268fda8d44b41 100644

--- a/Source/core/css/parser/SizesAttributeParserTest.cpp

+++ b/Source/core/css/parser/SizesAttributeParserTest.cpp

@@ -30,8 +30,8 @@ TEST(SizesAttributeParserTest, Basic)

{"400px, (min-width:500px) 200px", 400},

{"(min-width:5000px) 200px, 400px", 400},

{"(blalbadfsdf) 200px, 400px", 400},

- {"0", 500},

- {"-0", 500},

+ {"0", 0},

+ {"-0", 0},

{"1", 500},

{"300px, 400px", 300},

{"(min-width:5000px) 200px, (min-width:500px) 400px", 400},