Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 301743008: Update run-bindings-tests per compute_interfaces_info split (Closed)

Created:
5 years ago by Nils Barth (inactive)
Modified:
5 years ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Update run-bindings-tests per compute_interfaces_info split This updates r-b-t (currently breaking) following: Bindings build: split compute_interfaces_info into 2 stages https://codereview.chromium.org/300273005/ Sorry for breakage! This wasn't caught earlier because files were renamed, then changed, so the old bytecode (.pyc) was still being used. TBR=haraken BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174954

Patch Set 1 #

Patch Set 2 : Cleaner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -23 lines) Patch
M Source/bindings/scripts/compute_interfaces_info_individual.py View 1 3 chunks +12 lines, -7 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info_overall.py View 3 chunks +19 lines, -14 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Quick fix to r-b-t, which I just broke (>.<), sorry. (Includes some clarifying refactorings)
5 years ago (2014-05-28 08:45:31 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
5 years ago (2014-05-28 08:45:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/301743008/20001
5 years ago (2014-05-28 08:45:54 UTC) #3
haraken
LGTM.
5 years ago (2014-05-28 09:04:15 UTC) #4
commit-bot: I haz the power
5 years ago (2014-05-28 10:04:20 UTC) #5
Message was sent while issue was closed.
Change committed as 174954

Powered by Google App Engine
This is Rietveld 408576698