Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 301743008: Update run-bindings-tests per compute_interfaces_info split (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Cleaner Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/compute_interfaces_info_overall.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index d5e5889c10fa12ae8ece91c10be8b703ef83f79e..7a002965edceb966f00f8c54fa9955775ffc78ea 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -39,7 +39,10 @@ source_path = os.path.normpath(os.path.join(module_path, os.pardir, os.pardir,
os.pardir, os.pardir, 'Source'))
sys.path.append(source_path) # for Source/bindings imports
-from bindings.scripts.compute_interfaces_info import compute_interfaces_info, interfaces_info
+import bindings.scripts.compute_interfaces_info_individual
+from bindings.scripts.compute_interfaces_info_individual import compute_info_individual, info_individual
+import bindings.scripts.compute_interfaces_info_overall
+from bindings.scripts.compute_interfaces_info_overall import compute_interfaces_info_overall, interfaces_info
from bindings.scripts.idl_compiler import IdlCompilerV8
@@ -104,7 +107,12 @@ def generate_interface_dependencies():
# since this is also special-cased and Node inherits from EventTarget,
# but this inheritance information requires computing dependencies for
# the real Node.idl file.
- compute_interfaces_info(idl_paths_recursive(source_path))
+
+ # 2-stage computation: individual, then overall
+ for idl_filename in idl_paths_recursive(source_path):
+ compute_info_individual(idl_filename)
+ info_individuals = [info_individual()]
+ compute_interfaces_info_overall(info_individuals)
def bindings_tests(output_directory, verbose):
« no previous file with comments | « Source/bindings/scripts/compute_interfaces_info_overall.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698