Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 300273005: Bindings build: split compute_interfaces_info into 2 stages (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
haraken, Nico
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Bindings build: split compute_interfaces_info into 2 stages Preparatory refactoring: no changes to generated bindings. Next step in splitting bindings build is splitting compute_interfaces_info into core and modules. For several reasons, I'm *first* splitting the compute_interfaces_info step into two steps (vertical split): individual and overall. In follow-up I'll split the individual step in two – core and modules (horizontal split) – but to keep it simple I'll do that separately. The reasons are: 1. To treat different IDL files differently, depending on component; (In follow-up I'll split individual into core vs. modules, and then we'll finally be able to distinguish components in the CG, and generate qualified include paths w/o hideous path hacks!) 2. To avoid duplication (we want to avoid reading in all core IDL files for core, and then reading in all core IDL files *again* and module IDL files for modules); 3. Simplify build, by having simpler steps. R=haraken TBR=Nico BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174935

Patch Set 1 #

Patch Set 2 : Remove debugging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -468 lines) Patch
M Source/bindings/core/v8/generated.gyp View 2 chunks +72 lines, -1 line 0 comments Download
M Source/bindings/generated.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
M Source/bindings/modules/v8/generated.gyp View 1 chunk +1 line, -1 line 0 comments Download
D Source/bindings/scripts/compute_interfaces_info.py View 1 chunk +0 lines, -322 lines 0 comments Download
A Source/bindings/scripts/compute_interfaces_info_individual.py View 1 chunk +178 lines, -0 lines 0 comments Download
A + Source/bindings/scripts/compute_interfaces_info_overall.py View 1 5 chunks +27 lines, -102 lines 0 comments Download
M Source/bindings/scripts/utilities.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nils Barth (inactive)
6 years, 7 months ago (2014-05-28 03:34:37 UTC) #1
haraken
LGTM.
6 years, 7 months ago (2014-05-28 04:27:44 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-28 04:42:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/300273005/20001
6 years, 7 months ago (2014-05-28 04:43:06 UTC) #4
commit-bot: I haz the power
Change committed as 174935
6 years, 7 months ago (2014-05-28 06:01:37 UTC) #5
Nils Barth (inactive)
6 years, 7 months ago (2014-05-28 09:00:37 UTC) #6
Message was sent while issue was closed.
On 2014/05/28 06:01:37, I haz the power (commit-bot) wrote:
> Change committed as 174935

This broke run-bindings-tests; fixed in:
Update run-bindings-tests per compute_interfaces_info split
https://codereview.chromium.org/301743008/

Powered by Google App Engine
This is Rietveld 408576698