Refactor websocket connections logic with devtool Storage domain to a separate class

Refactor websocket connections logic with devtool Storage domain to a separate class

This is to make it consistent with how Telemetry communicates with other domains.
It also make it easier for future extensions (such as tracking events sendt from
Storage domain).

Review-Url: https://chromiumcodereview.appspot.com/3013243002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/aa736cc76ee5e35215abcfb83a8c354f12d0c684

[nednguyen, 2017-09-22 11:42:36]

nednguyen@google.com changed reviewers:
+ perezju@chromium.org

[nednguyen, 2017-09-22 11:42:42]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-09-22 11:42:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-22 12:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-22 12:14:22]

Dry run: This issue passed the CQ dry run.

[perezju, 2017-09-22 12:59:19]

lgtm

https://codereview.chromium.org/3013243002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome_inspector/inspector_storage.py
(right):

https://codereview.chromium.org/3013243002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome_inspector/inspector_storage.py:25:
if 'error' in res:
for a follow up, but maybe something like this should be the default within
SyncRequest?

[nednguyen, 2017-09-22 13:02:40]

https://codereview.chromium.org/3013243002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome_inspector/inspector_storage.py
(right):

https://codereview.chromium.org/3013243002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome_inspector/inspector_storage.py:25:
if 'error' in res:
On 2017/09/22 12:59:19, perezju wrote:
> for a follow up, but maybe something like this should be the default within
> SyncRequest?

Yeah, I was thinking the same too.

[nednguyen, 2017-09-22 13:02:44]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2017-09-22 13:02:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-22 13:04:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1506085364691570, "parent_rev":
"eb2e641ee3d16241847ea7b96ec54e992fb55b75", "commit_rev":
"aa736cc76ee5e35215abcfb83a8c354f12d0c684"}

[commit-bot: I haz the power, 2017-09-22 13:04:15]

Description was changed from

==========
Refactor websocket connections logic with devtool Storage domain to a separate
class

This is to make it consistent with how Telemetry communicates with other
domains.
It also make it easier for future extensions (such as tracking events sendt from
Storage domain).
==========

to

==========
Refactor websocket connections logic with devtool Storage domain to a separate
class

This is to make it consistent with how Telemetry communicates with other
domains.
It also make it easier for future extensions (such as tracking events sendt from
Storage domain).

Review-Url: https://chromiumcodereview.appspot.com/3013243002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-22 13:04:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...