Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py

Issue 3013243002: Refactor websocket connections logic with devtool Storage domain to a separate class (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
index 2547056dbc53c4b7c5f85c0ccf1977902b06f04e..1765f12ddaec552dd958f7ef9b9148e027d03c26 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
@@ -16,6 +16,7 @@ from telemetry.internal.backends.chrome_inspector import inspector_console
from telemetry.internal.backends.chrome_inspector import inspector_memory
from telemetry.internal.backends.chrome_inspector import inspector_page
from telemetry.internal.backends.chrome_inspector import inspector_runtime
+from telemetry.internal.backends.chrome_inspector import inspector_storage
from telemetry.internal.backends.chrome_inspector import inspector_websocket
from telemetry.internal.backends.chrome_inspector import websocket
from telemetry.util import js_template
@@ -71,6 +72,7 @@ class InspectorBackend(object):
self._page = inspector_page.InspectorPage(
self._websocket, timeout=timeout)
self._runtime = inspector_runtime.InspectorRuntime(self._websocket)
+ self._storage = inspector_storage.InspectorStorage(self._websocket)
except (websocket.WebSocketException, exceptions.TimeoutException,
py_utils.TimeoutException) as e:
self._ConvertExceptionFromInspectorWebsocket(e)
@@ -108,6 +110,9 @@ class InspectorBackend(object):
def debugger_url(self):
return self._context['webSocketDebuggerUrl']
+ def ClearDataForOrigin(self, url, timeout):
+ self._storage.ClearDataForOrigin(url, timeout)
+
def GetWebviewInspectorBackends(self):
"""Returns a list of InspectorBackend instances associated with webviews.

Powered by Google App Engine
This is Rietveld 408576698