Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: telemetry/telemetry/internal/browser/tab.py

Issue 3013243002: Refactor websocket connections logic with devtool Storage domain to a separate class (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/browser/tab.py
diff --git a/telemetry/telemetry/internal/browser/tab.py b/telemetry/telemetry/internal/browser/tab.py
index f67b9939f56be73ef3b86400c254bf2e09836f11..2d00c0f536a6024c053fe00203867f7b62e071ee 100644
--- a/telemetry/telemetry/internal/browser/tab.py
+++ b/telemetry/telemetry/internal/browser/tab.py
@@ -5,7 +5,6 @@
from telemetry.internal.actions import action_runner
from telemetry.internal.browser import web_contents
from telemetry.internal.image_processing import video
-from telemetry.core import exceptions
DEFAULT_TAB_TIMEOUT = 60
@@ -285,12 +284,4 @@ class Tab(web_contents.WebContents):
Raises:
exceptions.StoryActionError
"""
- res = self._inspector_backend._websocket.SyncRequest({
- 'method': 'Storage.clearDataForOrigin',
- 'params': {
- 'origin': url,
- 'storageTypes': 'all'
- }
- }, timeout)
- if 'error' in res:
- raise exceptions.StoryActionError(res['error']['message'])
+ return self._inspector_backend.ClearDataForOrigin(url, timeout)

Powered by Google App Engine
This is Rietveld 408576698