Oilpan: use transition types for remaining RefPtr<Document>s in dom/.

Oilpan: use transition types for remaining RefPtr<Document>s in dom/.

Switch to RefPtrWillBeRawPtr<>/RefPtrWillBeMember<> instead.

R=haraken@chromium.org
BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175316

[sof, 2014-06-02 14:29:30]

Please take a look.

All remaining bar one :) Left IncrementLoadEventDelayCount as holding a
RefPtr<Document> -- will separately try to avoid introducing a Persistent just
for it.

[haraken, 2014-06-02 14:38:42]

https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp#ne...
Source/core/dom/Range.cpp:110: m_ownerDocument->detachRange(this);

You cannot touch an on-heap object in a destructor.

I guess you need to make Document::m_range a hash set of weak members and remove
this line from oilpan builds.

[sof, 2014-06-02 14:41:01]

https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp#ne...
Source/core/dom/Range.cpp:110: m_ownerDocument->detachRange(this);
On 2014/06/02 14:38:43, haraken wrote:
> 
> You cannot touch an on-heap object in a destructor.
> 
> I guess you need to make Document::m_range a hash set of weak members and
remove
> this line from oilpan builds.

Sorry, forgot to check this dtor. Will address.

[sof, 2014-06-02 16:26:18]

https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp#ne...
Source/core/dom/Range.cpp:110: m_ownerDocument->detachRange(this);
On 2014/06/02 14:41:02, sof wrote:
> On 2014/06/02 14:38:43, haraken wrote:
> > 
> > You cannot touch an on-heap object in a destructor.
> > 
> > I guess you need to make Document::m_range a hash set of weak members and
> remove
> > this line from oilpan builds.
> 
> Sorry, forgot to check this dtor. Will address.

Done.

[haraken, 2014-06-02 16:31:47]

LGTM.

[sof, 2014-06-02 18:28:36]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-06-02 18:29:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/301233010/40001

[commit-bot: I haz the power, 2014-06-02 21:34:46]

Change committed as 175316

[Mads Ager (chromium), 2014-06-03 08:58:09]

LGTM2

It does seem like the Range pointers need the weak processing currently.