Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 301233010: Oilpan: use transition types for remaining RefPtr<Document>s in dom/. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: use transition types for remaining RefPtr<Document>s in dom/. Switch to RefPtrWillBeRawPtr<>/RefPtrWillBeMember<> instead. R=haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175316

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove superfluous empty line #

Patch Set 3 : Have Document weakly track its attached Ranges #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -42 lines) Patch
M Source/bindings/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8DocumentCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 12 chunks +19 lines, -18 lines 0 comments Download
M Source/core/dom/DocumentMarkerControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Range.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScopeTest.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look. All remaining bar one :) Left IncrementLoadEventDelayCount as holding a RefPtr<Document> ...
6 years, 6 months ago (2014-06-02 14:29:30 UTC) #1
haraken
https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp File Source/core/dom/Range.cpp (right): https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp#newcode110 Source/core/dom/Range.cpp:110: m_ownerDocument->detachRange(this); You cannot touch an on-heap object in a ...
6 years, 6 months ago (2014-06-02 14:38:42 UTC) #2
sof
https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp File Source/core/dom/Range.cpp (right): https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp#newcode110 Source/core/dom/Range.cpp:110: m_ownerDocument->detachRange(this); On 2014/06/02 14:38:43, haraken wrote: > > You ...
6 years, 6 months ago (2014-06-02 14:41:01 UTC) #3
sof
https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp File Source/core/dom/Range.cpp (right): https://codereview.chromium.org/301233010/diff/1/Source/core/dom/Range.cpp#newcode110 Source/core/dom/Range.cpp:110: m_ownerDocument->detachRange(this); On 2014/06/02 14:41:02, sof wrote: > On 2014/06/02 ...
6 years, 6 months ago (2014-06-02 16:26:18 UTC) #4
haraken
LGTM.
6 years, 6 months ago (2014-06-02 16:31:47 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-02 18:28:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/301233010/40001
6 years, 6 months ago (2014-06-02 18:29:04 UTC) #7
commit-bot: I haz the power
Change committed as 175316
6 years, 6 months ago (2014-06-02 21:34:46 UTC) #8
Mads Ager (chromium)
6 years, 6 months ago (2014-06-03 08:58:09 UTC) #9
Message was sent while issue was closed.
LGTM2

It does seem like the Range pointers need the weak processing currently.

Powered by Google App Engine
This is Rietveld 408576698