Source/core/dom/DocumentMarkerControllerTest.cpp - Issue 301233010: Oilpan: use transition types for remaining RefPtr<Document>s in dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DocumentMarkerControllerTest.cpp

Issue 301233010: Oilpan: use transition types for remaining RefPtr<Document>s in dom/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have Document weakly track its attached Ranges Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DocumentMarkerControllerTest.cpp

diff --git a/Source/core/dom/DocumentMarkerControllerTest.cpp b/Source/core/dom/DocumentMarkerControllerTest.cpp

index 94a46cf3c43200dc01b929afbec1d441d3921353..927b243b9f9cb6010a4410bff44e6e354bc1bdb6 100644

--- a/Source/core/dom/DocumentMarkerControllerTest.cpp

+++ b/Source/core/dom/DocumentMarkerControllerTest.cpp

@@ -94,7 +94,7 @@ TEST_F(DocumentMarkerControllerTest, DidMoveToNewDocument)

RefPtrWillBeRawPtr<Element> parent = toElement(document().body()->firstChild()->firstChild());

markNodeContents(parent.get());

EXPECT_EQ(1u, markerController().markers().size());

- RefPtr<Document> anotherDocument = Document::create();

+ RefPtrWillBePersistent<Document> anotherDocument = Document::create();

anotherDocument->adoptNode(parent.get(), ASSERT_NO_EXCEPTION);

// No more reference to marked node.

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/FullscreenElementStack.cpp » ('j') | no next file with comments »