Source/core/dom/ContainerNode.cpp - Issue 301233010: Oilpan: use transition types for remaining RefPtr<Document>s in dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.cpp

Issue 301233010: Oilpan: use transition types for remaining RefPtr<Document>s in dom/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have Document weakly track its attached Ranges Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ContainerNode.cpp

diff --git a/Source/core/dom/ContainerNode.cpp b/Source/core/dom/ContainerNode.cpp

index caf75b145a1878cf14f938375842cc74ff8e5fc6..406ca8b737d8ddfc56f8db3c601745c74b421dcf 100644

--- a/Source/core/dom/ContainerNode.cpp

+++ b/Source/core/dom/ContainerNode.cpp

@@ -1028,8 +1028,8 @@ static void dispatchChildInsertionEvents(Node& child)

ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());

- RefPtr<Node> c(child);

- RefPtr<Document> document(child.document());

+ RefPtrWillBeRawPtr<Node> c(child);

+ RefPtrWillBeRawPtr<Document> document(child.document());

if (c->parentNode() && document->hasListenerType(Document::DOMNODEINSERTED_LISTENER))

c->dispatchScopedEvent(MutationEvent::create(EventTypeNames::DOMNodeInserted, true, c->parentNode()));

@@ -1052,8 +1052,8 @@ static void dispatchChildRemovalEvents(Node& child)

InspectorInstrumentation::willRemoveDOMNode(&child);

- RefPtr<Node> c(child);

- RefPtr<Document> document(child.document());

+ RefPtrWillBeRawPtr<Node> c(child);

+ RefPtrWillBeRawPtr<Document> document(child.document());

// dispatch pre-removal mutation events

if (c->parentNode() && document->hasListenerType(Document::DOMNODEREMOVED_LISTENER)) {

« no previous file with comments | « Source/bindings/v8/custom/V8DocumentCustom.cpp ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »