Source/bindings/v8/custom/V8DocumentCustom.cpp - Issue 301233010: Oilpan: use transition types for remaining RefPtr<Document>s in dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8DocumentCustom.cpp

Issue 301233010: Oilpan: use transition types for remaining RefPtr<Document>s in dom/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have Document weakly track its attached Ranges Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8DocumentCustom.cpp

diff --git a/Source/bindings/v8/custom/V8DocumentCustom.cpp b/Source/bindings/v8/custom/V8DocumentCustom.cpp

index f88483279132c0223f851d1cfb4071f7071b8dcd..156c32740a7ba9afa620333c5054dbccdf38a840 100644

--- a/Source/bindings/v8/custom/V8DocumentCustom.cpp

+++ b/Source/bindings/v8/custom/V8DocumentCustom.cpp

@@ -60,7 +60,7 @@ namespace WebCore {

void V8Document::evaluateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- RefPtr<Document> document = V8Document::toNative(info.Holder());

+ RefPtrWillBeRawPtr<Document> document = V8Document::toNative(info.Holder());

ASSERT(document);

ExceptionState exceptionState(ExceptionState::ExecutionContext, "evaluate", "Document", info.Holder(), info.GetIsolate());

TOSTRING_VOID(V8StringResource<>, expression, info[0]);

« no previous file with comments | « Source/bindings/v8/ScriptController.cpp ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »