improve recovery of invalid top level abstract modifier usage

improve recovery of invalid top level abstract modifier usage

The fasta parser now gracefully degrades if the user puts 'abstract' before a top level declaration other than 'class'.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/5f5386b404f915f8cef0fc380dcdee512911594f

[danrubel, 2017-08-30 01:45:11]

danrubel@google.com changed reviewers:
+ ahe@google.com

[danrubel, 2017-08-30 02:18:12]

Description was changed from

==========
improve recovery of invalid top level abstract modifier usage
==========

to

==========
improve recovery of invalid top level abstract modifier usage

The fasta parser now gracefully degrades if the user puts 'abstract' before a
top level declaration other than 'class'.
==========

[ahe, 2017-08-30 12:29:22]

Could you add a test of this to pkg/front_end/testcases/?

I'd like to ensure that each new feature we implement in pkg/front_end is tested
outside package:analyzer's unit tests.

[ahe, 2017-08-30 14:04:05]

lgtm

As we discussed in our meeting, you'll add tests in a later CL.

[danrubel, 2017-08-31 11:28:47]

Description was changed from

==========
improve recovery of invalid top level abstract modifier usage

The fasta parser now gracefully degrades if the user puts 'abstract' before a
top level declaration other than 'class'.
==========

to

==========
improve recovery of invalid top level abstract modifier usage

The fasta parser now gracefully degrades if the user puts 'abstract' before a
top level declaration other than 'class'.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5f5386b404f915f8cef0fc380dcdee512911594f
==========

[danrubel, 2017-08-31 11:28:48]

Committed patchset #3 (id:40001) manually as
5f5386b404f915f8cef0fc380dcdee512911594f (presubmit successful).

[danrubel, 2017-08-31 21:11:09]

On 2017/08/30 12:29:22, ahe wrote:
> Could you add a test of this to pkg/front_end/testcases/?
> 
> I'd like to ensure that each new feature we implement in pkg/front_end is
tested
> outside package:analyzer's unit tests.

I've added additional tests in messages.yaml in
https://codereview.chromium.org/3007943002 and started implementing
messages.yaml tests in https://codereview.chromium.org/3010843002/