gracefully recover from extraneous top level modifiers

gracefully recover from extraneous top level modifiers

When the user includes extraneous modifiers preceeding top level
directives and declarations, the fasta parser now report an error
and skips the modifier.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/813d4eddf86559d4225d3389425a31302a14e034

[danrubel, 2017-08-31 19:42:58]

danrubel@google.com changed reviewers:
+ ahe@google.com, brianwilkerson@google.com

[Brian Wilkerson, 2017-08-31 20:05:52]

lgtm

https://codereview.chromium.org/3007943002/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/parser_fasta_test.dart (right):

https://codereview.chromium.org/3007943002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/parser_fasta_test.dart:4246:
//super.test_parseCompilationUnit_builtIn_asFunctionName();
Perhaps a comment explaining that this is the subset that now pass and that the
failing identifiers are in test_parseCompilationUnit_builtIn_asFunctionName2?

[danrubel, 2017-08-31 21:24:54]

https://codereview.chromium.org/3007943002/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/parser_fasta_test.dart (right):

https://codereview.chromium.org/3007943002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/parser_fasta_test.dart:4246:
//super.test_parseCompilationUnit_builtIn_asFunctionName();
On 2017/08/31 20:05:52, Brian Wilkerson wrote:
> Perhaps a comment explaining that this is the subset that now pass and that
the
> failing identifiers are in test_parseCompilationUnit_builtIn_asFunctionName2?

Good idea. Done.

[ahe, 2017-09-01 14:42:52]

I'm having a hard time putting my thoughts together on this one. Can we discuss
this in person?

https://codereview.chromium.org/3007943002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/3007943002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/parser/parser.dart:277: Link<Token> modifiers =
const Link<Token>();
Perhaps we can take advantage of the next pointer in the tokens themselves? That
is, not create a Link?

https://codereview.chromium.org/3007943002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/parser/parser.dart:1613: [Token start, Link<Token>
identifiers = const Link<Token>()]) {
I try to avoid optional arguments in the parser, as I'm not sure they have great
performance.

[danrubel, 2017-09-01 15:13:55]

https://codereview.chromium.org/3007943002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/3007943002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/parser/parser.dart:277: Link<Token> modifiers =
const Link<Token>();
On 2017/09/01 14:42:52, ahe wrote:
> Perhaps we can take advantage of the next pointer in the tokens themselves?
That
> is, not create a Link?

I was following what you do in parseTopLevelMember so that we would not check
modifier tokens more than once. That said, I like your idea about using the next
token pointer rather than creating a separate Link object. I'll take another
crack at it.

[danrubel, 2017-09-01 16:54:49]

Revised per discussion. PTAL.

[Brian Wilkerson, 2017-09-01 17:10:44]

lgtm

[danrubel, 2017-09-01 22:55:10]

Description was changed from

==========
gracefully recover from extraneous top level modifiers

When the user includes extraneous modifiers preceeding top level
directives and declarations, the fasta parser now report an error
and skips the modifier.
==========

to

==========
gracefully recover from extraneous top level modifiers

When the user includes extraneous modifiers preceeding top level
directives and declarations, the fasta parser now report an error
and skips the modifier.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/813d4eddf86559d4225d3389425a31302a14e034
==========

[danrubel, 2017-09-01 22:55:12]

Committed patchset #5 (id:80001) manually as
813d4eddf86559d4225d3389425a31302a14e034 (presubmit successful).