message.yaml test - first cut

message.yaml test - first cut

[danrubel, 2017-08-31 21:06:25]

danrubel@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-09-01 12:27:55]

lgtm

https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
File pkg/front_end/test/fasta/messages_test.dart (right):

https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
pkg/front_end/test/fasta/messages_test.dart:10: Uri messagesFile =
Platform.script.resolve("../../messages.yaml");
I think this is more reliable:

Uri.base.resolve("pkg/front_end/messages.yaml")

https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
pkg/front_end/test/fasta/messages_test.dart:11: Map yaml = loadYaml(await new
File.fromUri(messagesFile).readAsStringSync());
Remove Sync.

https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
pkg/front_end/test/fasta/messages_test.dart:40: print('$missingDart2jsCode error
codes missing dart2js code');
We don't need dart2js error codes for all errors. We only need them for the ones
that are generated by the parser.

https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
pkg/front_end/test/fasta/messages_test.dart:49: : 0;
In Dart, main's return value is ignored. So how about just deleting these lines?

[danrubel, 2017-09-15 12:44:16]

On 2017/09/01 12:27:55, ahe wrote:
> lgtm
> 
>
https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
> File pkg/front_end/test/fasta/messages_test.dart (right):
> 
>
https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
> pkg/front_end/test/fasta/messages_test.dart:10: Uri messagesFile =
> Platform.script.resolve("../../messages.yaml");
> I think this is more reliable:
> 
> Uri.base.resolve("pkg/front_end/messages.yaml")
> 
>
https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
> pkg/front_end/test/fasta/messages_test.dart:11: Map yaml = loadYaml(await new
> File.fromUri(messagesFile).readAsStringSync());
> Remove Sync.
> 
>
https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
> pkg/front_end/test/fasta/messages_test.dart:40: print('$missingDart2jsCode
error
> codes missing dart2js code');
> We don't need dart2js error codes for all errors. We only need them for the
ones
> that are generated by the parser.
> 
>
https://codereview.chromium.org/3010843002/diff/1/pkg/front_end/test/fasta/me...
> pkg/front_end/test/fasta/messages_test.dart:49: : 0;
> In Dart, main's return value is ignored. So how about just deleting these
lines?

Moved to and addressed comments in
https://dart-review.googlesource.com/c/sdk/+/5285