Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: pkg/analyzer/test/generated/parser_fasta_test.dart

Issue 3010713002: improve recovery of invalid top level abstract modifier usage (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/parser_fasta_test.dart
diff --git a/pkg/analyzer/test/generated/parser_fasta_test.dart b/pkg/analyzer/test/generated/parser_fasta_test.dart
index 339bb2727a2f9e9e9f3ca9d6b0fe15c2475eee14..dc0ef3f91e1fcf4bcee91470ea95d42547de5084 100644
--- a/pkg/analyzer/test/generated/parser_fasta_test.dart
+++ b/pkg/analyzer/test/generated/parser_fasta_test.dart
@@ -139,18 +139,6 @@ class ComplexParserTest_Fasta extends FastaParserTestCase
@reflectiveTest
class ErrorParserTest_Fasta extends FastaParserTestCase
with ErrorParserTestMixin {
- @override
- @failingTest
- void test_abstractEnum() {
- super.test_abstractEnum();
- }
-
- @override
- @failingTest
- void test_abstractTypeDef() {
- super.test_abstractTypeDef();
- }
-
@override
@failingTest
void test_annotationOnEnumConstant_first() {
@@ -2573,8 +2561,10 @@ class FastaParserTestCase extends Object
List<ErrorCode> expectedErrorCodes) =>
expectedErrorCodes.map((code) {
if (code == ParserErrorCode.ABSTRACT_CLASS_MEMBER ||
+ code == ParserErrorCode.ABSTRACT_ENUM ||
code == ParserErrorCode.ABSTRACT_TOP_LEVEL_FUNCTION ||
- code == ParserErrorCode.ABSTRACT_TOP_LEVEL_VARIABLE)
+ code == ParserErrorCode.ABSTRACT_TOP_LEVEL_VARIABLE ||
+ code == ParserErrorCode.ABSTRACT_TYPEDEF)
return ParserErrorCode.EXTRANEOUS_MODIFIER;
return code;
}).toList();
@@ -4611,6 +4601,13 @@ class TopLevelParserTest_Fasta extends FastaParserTestCase
test_parseClassDeclaration_native();
}
+ @override
+ @failingTest
+ void test_parseCompilationUnit_abstractAsPrefix_parameterized() {
+ // TODO(danrubel): built-in "abstract" cannot be used as a type
+ super.test_parseCompilationUnit_abstractAsPrefix_parameterized();
+ }
+
@override
@failingTest
void test_parseCompilationUnit_builtIn_asFunctionName() {
@@ -4648,6 +4645,13 @@ class TopLevelParserTest_Fasta extends FastaParserTestCase
assertNoErrors();
}
+ @override
+ @failingTest
+ void test_parseCompilationUnitMember_abstractAsPrefix() {
+ // TODO(danrubel): built-in "abstract" cannot be used as a prefix
+ super.test_parseCompilationUnitMember_abstractAsPrefix();
+ }
+
@failingTest
void test_parseCompilationUnitMember_abstractAsPrefix2() {
// TODO(danrubel): should not be generating an error
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698