fix list_test for strong mode, and fix DDC List constructors

fix list_test for strong mode, and fix DDC List constructors

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/087c5c6a8151eabab66e7e8b3517129dfb462b4a

[Jennifer Messerly, 2017-08-25 18:08:57]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2017-08-25 18:08:58]

https://codereview.chromium.org/3009623002/diff/1/pkg/dev_compiler/tool/ddc
File pkg/dev_compiler/tool/ddc (right):

https://codereview.chromium.org/3009623002/diff/1/pkg/dev_compiler/tool/ddc#n...
pkg/dev_compiler/tool/ddc:28: console.error(e.toString(),
sdk.dart.stackTrace(e).toString());
This is to make sure the error stack trace prints.

(I think we aren't putting ours where JS engines expect, but that's a separate
issue... for now this makes tests a bit more debuggable)

https://codereview.chromium.org/3009623002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart (right):

https://codereview.chromium.org/3009623002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart:326: factory List([_length
= undefined]) {
the List constructor does a weird thing in dart2js where they test against a
private const object to determine if `length` was passed or not. For us I
introduced an `undefined` constant and allow it do skip the optional arg
initialization

https://codereview.chromium.org/3009623002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart:328: if (JS('bool', '# ===
void 0', _length)) {
maybe we should recognize `undefined` in other places and replace with `void 0`
... but I don't need that yet, so I didn't bother.

https://codereview.chromium.org/3009623002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart:343: factory
List.filled(@nullCheck int length, E fill, {bool growable: false}) {
there's a couple of bug fixes here

https://codereview.chromium.org/3009623002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart:344: var list = new
JSArray<E>.of(JS('', 'new Array(#)', length));
this was incorrectly fixed in the old code because it used `new List(length)`

https://codereview.chromium.org/3009623002/diff/1/tests/corelib_2/list_test.dart
File tests/corelib_2/list_test.dart (left):

https://codereview.chromium.org/3009623002/diff/1/tests/corelib_2/list_test.d...
tests/corelib_2/list_test.dart:478: // Operations that change the length cause
ConcurrentModificationError.
these were split into a new test

[Jennifer Messerly, 2017-08-25 18:09:10]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2017-08-25 18:10:01]

Hi there! This CL has some bug fixes I came across while investigating List
performance. It doesn't do anything for performance (other than a little bit of
inlining)

[Jennifer Messerly, 2017-08-25 18:15:42]

Also oops, I need to mark some of the const_list tests passing now. Working on a
status file update.

[Jennifer Messerly, 2017-08-25 19:31:14]

FYI: this CL is ready now! sorry for sending it out prematurely :)

[vsm, 2017-08-26 00:18:37]

lgtm

https://codereview.chromium.org/3009623002/diff/10001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart (right):

https://codereview.chromium.org/3009623002/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart:13: const
undefined = null;
Explicit Null?

[Jennifer Messerly, 2017-08-26 01:32:53]

Description was changed from

==========
fix list_test for strong mode, and fix DDC List constructors
==========

to

==========
fix list_test for strong mode, and fix DDC List constructors

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/087c5c6a8151eabab66e7e8b3517129dfb462b4a
==========

[Jennifer Messerly, 2017-08-26 01:32:56]

Committed patchset #2 (id:10001) manually as
087c5c6a8151eabab66e7e8b3517129dfb462b4a (presubmit successful).