pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart - Issue 3009623002: fix list_test for strong mode, and fix DDC List constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

Issue 3009623002: fix list_test for strong mode, and fix DDC List constructors (Closed)

Patch Set: update status, one additional fix Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

index 4075646b8e11fc05a496381658b5d14c63ab11f9..b33748a49c1a00c0592b97d31fd695b6d994c538 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart

@@ -7,6 +7,11 @@ part of dart._runtime;

/// by the Dart runtime.

// TODO(ochafik): Rewrite some of these in Dart when possible.

+/// The JavaScript undefined constant.

+///

+/// This is initialized by DDC to JS void 0.

+const undefined = null;

vsm 2017/08/26 00:18:37 Explicit Null?

defineProperty(obj, name, desc) =>

JS('', 'Object.defineProperty(#, #, #)', obj, name, desc);