Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/isolate_serialization.dart

Issue 3009623002: fix list_test for strong mode, and fix DDC List constructors (Closed)
Patch Set: update status, one additional fix Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/private/isolate_serialization.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/isolate_serialization.dart b/pkg/dev_compiler/tool/input_sdk/private/isolate_serialization.dart
index be2a25f3bd3bc98ebbbaa39707d0f1e5ea9e8603..67b2cc451e297a9a0bcde92652fd3165e39f2b52 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/isolate_serialization.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/isolate_serialization.dart
@@ -263,7 +263,7 @@ class _Deserializer {
assert(x[0] == 'fixed');
List result = x[1];
deserializedObjects.add(result);
- return new JSArray.markFixed(deserializeArrayInPlace(result));
+ return new JSArray.fixed(deserializeArrayInPlace(result));
}
// ['extendable', <array>].
@@ -271,7 +271,7 @@ class _Deserializer {
assert(x[0] == 'extendable');
List result = x[1];
deserializedObjects.add(result);
- return new JSArray.markGrowable(deserializeArrayInPlace(result));
+ return new JSArray.of(deserializeArrayInPlace(result));
}
// ['mutable', <array>].
@@ -288,7 +288,7 @@ class _Deserializer {
List result = x[1];
deserializedObjects.add(result);
// TODO(floitsch): need to mark list as non-changeable.
- return new JSArray.markFixed(deserializeArrayInPlace(result));
+ return new JSArray.unmodifiable(deserializeArrayInPlace(result));
}
// ['map', <key-list>, <value-list>].

Powered by Google App Engine
This is Rietveld 408576698