pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart - Issue 3009623002: fix list_test for strong mode, and fix DDC List constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 3009623002: fix list_test for strong mode, and fix DDC List constructors (Closed)

Patch Set: update status, one additional fix Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart » ('j') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

index 91f541ea3cf5789bb0091a2c03ac2ee745ba91be..13d0a3ad42d88ff38422430377d02bb3db3d343f 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -858,9 +858,9 @@ constList(elements, elementType) => JS('', '''(() => {

let value = map.get($elementType);

if (value) return value;

- value = $setType($elements, ${getGenericClass(JSArray)}($elementType));

- map.set($elementType, value);

- return value;

+ ${getGenericClass(JSArray)}($elementType).unmodifiable($elements);

+ map.set($elementType, elements);

+ return elements;

})()''');

// The following are helpers for Object methods when the receiver