Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 300863004: Qualify include paths in bindings/v8/custom (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Qualify include paths in bindings/v8/custom Mechanical change, mostly bindings/core/v8, a few bindings/modules/v8. (This will make sorting custom bindings trivial.) 2 exceptions due to files generated outside of bindings: V8HTMLElementWrapperFactory.h V8SVGElementWrapperFactory.h ...which are generated by core_generated.gyp in gen/blink. FIXMEs added. (core_generated.gyp also requires qualifying all its paths, but that's another kettle of fish) R=haraken BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174970

Patch Set 1 #

Patch Set 2 : Fix sorting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -252 lines) Patch
M Source/bindings/v8/custom/V8AudioNodeCustom.cpp View 1 chunk +18 lines, -18 lines 0 comments Download
M Source/bindings/v8/custom/V8BlobCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8BlobCustomHelpers.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSRuleCustom.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CSSValueCustom.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/v8/custom/V8ClientCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CryptoCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomEventCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8DeviceMotionEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8DocumentCustom.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/bindings/v8/custom/V8ElementCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8EntryCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8EntrySyncCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8ErrorEventCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8EventCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8EventTargetCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8FileCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8FileReaderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8GeolocationCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLCollectionCustom.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLElementCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HistoryCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8ImageDataCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8LocationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MessageChannelCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8MessagePortCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8NodeCustom.cpp View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/bindings/v8/custom/V8PerformanceEntryCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8PopStateEventCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8SVGElementCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8SVGPathSegCustom.cpp View 1 chunk +21 lines, -21 lines 0 comments Download
M Source/bindings/v8/custom/V8ServiceWorkerCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8StyleSheetCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8SubtleCryptoCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8TextCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8TextTrackCueCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8TrackEventCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp View 1 chunk +35 lines, -35 lines 0 comments Download
M Source/bindings/v8/custom/V8WebKitPointCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8WorkerCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WorkerGlobalScopeCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Mostly mechanical change.
6 years, 6 months ago (2014-05-28 12:30:16 UTC) #1
haraken
rubberstamp LGTM.
6 years, 6 months ago (2014-05-28 12:44:46 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-05-28 12:44:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/300863004/20001
6 years, 6 months ago (2014-05-28 12:45:11 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 14:09:54 UTC) #5
Message was sent while issue was closed. 
Change committed as 174970

Powered by Google App Engine
This is Rietveld 408576698