Merge DevTools Refactor CL to Blink36

Refactor devtools to place Dart and V8 as peers instead of bolting Dart support onto V8 support.

Code review tweaks

Tweaks from code review of sister CL.

Conflicts:
	Source/bindings/dart/DartApplicationLoader.cpp
	Source/bindings/dart/DartDebugHooks.js
	Source/bindings/dart/DartDebugServer.cpp
	Source/bindings/dart/DartUtilities.h
	Source/bindings/dart/custom/DartInjectedScriptHostCustom.cpp
	Source/bindings/dart/gyp/overrides.gypi
	Source/bindings/v8/PageScriptDebugServer.cpp
	Source/bindings/v8/ScriptDebugServer.cpp
	Source/bindings/v8/ScriptDebugServer.h
	Source/bindings/v8/ScriptValue.h
	Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
	Source/core/inspector/InjectedScriptHost.h
	Source/core/inspector/InspectorDOMAgent.cpp
	Source/core/inspector/InspectorDebuggerAgent.cpp
	Source/devtools/front_end/DebuggerModel.js
	Source/devtools/front_end/RemoteObject.js
	Source/devtools/front_end/RuntimeModel.js

Refactor devtools to place Dart and V8 as peers instead of bolting Dart support onto V8 support.

Code review tweaks

Tweaks from code review of sister CL.

Conflicts:
	Source/bindings/dart/DartApplicationLoader.cpp
	Source/bindings/dart/DartDebugHooks.js
	Source/bindings/dart/DartDebugServer.cpp
	Source/bindings/dart/DartUtilities.h
	Source/bindings/dart/custom/DartInjectedScriptHostCustom.cpp
	Source/bindings/dart/gyp/overrides.gypi
	Source/bindings/v8/PageScriptDebugServer.cpp
	Source/bindings/v8/ScriptDebugServer.cpp
	Source/bindings/v8/ScriptDebugServer.h
	Source/bindings/v8/ScriptValue.h
	Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
	Source/core/inspector/InjectedScriptHost.h
	Source/core/inspector/InspectorDOMAgent.cpp
	Source/core/inspector/InspectorDebuggerAgent.cpp
	Source/devtools/front_end/DebuggerModel.js
	Source/devtools/front_end/RemoteObject.js
	Source/devtools/front_end/RuntimeModel.js

Files with 35-36 merge Conflicts:
	Source/bindings/dart/DartUtilities.h
	Source/bindings/v8/ScriptDebugServer.cpp
	Source/bindings/v8/ScriptDebugServer.h
	Source/core/inspector/AsyncCallStackTracker.cpp
	Source/core/inspector/ConsoleMessage.cpp
	Source/core/inspector/InjectedScriptBase.h
	Source/core/inspector/InjectedScriptManager.cpp
	Source/core/inspector/InjectedScriptModule.cpp
	Source/core/inspector/InspectorCanvasAgent.cpp
	Source/core/inspector/InspectorController.cpp
	Source/core/inspector/InspectorDOMAgent.cpp
	Source/core/inspector/InspectorDebuggerAgent.cpp
	Source/core/inspector/InspectorDebuggerAgent.h
	Source/core/inspector/InspectorHeapProfilerAgent.cpp
	Source/core/inspector/InspectorRuntimeAgent.cpp
	Source/core/inspector/PageDebuggerAgent.cpp
	Source/core/inspector/PageRuntimeAgent.cpp
	Source/core/inspector/WorkerRuntimeAgent.cpp
	Source/devtools/front_end/DebuggerModel.js
	Source/devtools/front_end/ObjectPropertiesSection.js
	Source/devtools/front_end/RemoteObject.js
	Source/devtools/front_end/RuntimeModel.js
	Source/devtools/front_end/ScopeChainSidebarPane.js
	Source/web/WebDevToolsAgentImpl.cpp

BUG=
R=rmacnak@google.com

Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=175418

[Jacob, 2014-06-03 00:46:35]

Merge history with the previous CL wouldn't be that helpful because of the 34-36
churn.  Please take a look at this CL over the next day and provide comments. I
would like to get this in for 1.5 if possible as the devtools experience is
significantly improved. As before, vsm please look at the dart devtools portion
of the CL and rmacnak please look as the multivm related portion.
rmacnak I still owe you some refactors of the multivm related portion of the cl
but they should be restricted to the couple of files that are or should be in
common. ScriptValue, InjectedScriptBase.h, InjectedScript.h

[vsm, 2014-06-03 14:24:49]

https://chromiumcodereview.appspot.com/300393002/diff/20001/LayoutTests/dart/...
File LayoutTests/dart/inspector/evaluate-in-console.html (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/LayoutTests/dart/...
LayoutTests/dart/inspector/evaluate-in-console.html:86: // dartbug.com/18646 is
fixed.
This is marked fixed now.  Re-enable?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
File Source/bindings/common/ScriptValue.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:217: {
ASSERT(m_isJavaScript) ?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:222: {
ASSERT(!m_isJavaScript) ?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:262: Dart_ActivationFrame asDart() const {
return m_dartActivationFrame; }
Ditto on asserts for these two.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartController.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartController.cpp:208: if (isDebuggerEnabled) {
When is this enabled?  I seem to hit this path regardless of whether devtools is
open.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:132: ASSERT(!Dart_IsError(result));
ASSERT(length % 2 == 0);

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:49: enum Type {
Consider "Kind".

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:51: ObjectClass,
What's the difference between ObjectClass, Class, and StaticClass below?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:63:
DartDebuggerObject(Dart_PersistentHandle, const String& objectGroup, Type);
What is objectGroup here?  We use the term for GC - is this something similar?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:71: Dart_PersistentHandle m_handle;
Free handle in destructor?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:187: typedef HashMap<String,
DartDebuggerObject*> DebuggerObjectMap;
Unless these two maps can have NULL values, probably better off eliminating the
pointer.  E.g.,

typedef HashMap<String, Vector<String> >

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartScriptDebugServer.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartScriptDebugServer.h:57: {
Do you want to assert whether the value is already present?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/v...
File Source/bindings/v8/PageScriptDebugServer.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/v...
Source/bindings/v8/PageScriptDebugServer.cpp:35: #include
"bindings/dart/DartScriptDebugServer.h"
I think you just deleted the only reference to this.  Do you need to include?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/v...
File Source/bindings/v8/ScriptCallStackFactory.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/v...
Source/bindings/v8/ScriptCallStackFactory.h:50: ScriptCallFrame
toScriptCallFrame(v8::Handle<v8::StackFrame>);
Upstream to multivm?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/v...
File Source/bindings/v8/ScriptDebugServer.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/v...
Source/bindings/v8/ScriptDebugServer.h:57: class ScriptDebugServerBase {
move to common?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/v...
Source/bindings/v8/ScriptDebugServer.h:58: public:
I think you need a virtual destructor on this class.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/v...
Source/bindings/v8/ScriptDebugServer.h:101: class ScriptDebugServer : public
ScriptDebugServerBase {
Rename to V8ScriptDebugServer?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
File Source/core/inspector/InjectedScript.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
Source/core/inspector/InjectedScript.h:48: class InjectedScript : public virtual
InjectedScriptBase {
Should this class be moved to bindings?  Or, perhaps, core/inspector/v8 and
core/inspecter/dart?  The current mapping of classes to files to dirs is rather
confusing.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
File Source/core/inspector/InjectedScriptBase.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
Source/core/inspector/InjectedScriptBase.h:58: class V8InjectedScriptBase :
public virtual InjectedScriptBase {
The virtual base class feels kind of nasty.  Not sure I've seen it in blink code
either.

Is InjectedScriptBase an instantiated class?  If not, maybe this could be folded
into V8InjectedScript.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
File Source/core/inspector/InjectedScriptManager.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
Source/core/inspector/InjectedScriptManager.h:57: InjectedScript&
injectedScriptFor(ScriptState*);
Rather than making these changes, you might try Ryan's pattern for classes
passed or returned by value - e.g., see bindings/common/ScriptValue.

[rmacnak, 2014-06-03 17:32:34]

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
File Source/bindings/common/ScriptValue.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:233: ScriptValue m_scriptValue;
RefPtr<V8ScriptValue>

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:266: ScriptValue m_scriptValue;
RefPtr<V8ScriptValue>

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:128: Dart_Handle
findThisVariable(Dart_Handle locals)
findReceiver

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartScriptDebugServer.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartScriptDebugServer.cpp:361: // FIXME: we can get rid of
the V8Scope once DartScriptState and
Can we remove this now?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartUtilities.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartUtilities.h:223: static ScriptState*
v8ScriptStateForCurrentIsolate();
V8ScriptState

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
File Source/core/inspector/InjectedScriptBase.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
Source/core/inspector/InjectedScriptBase.h:85: ScriptObject
m_injectedScriptObject;
Add a note this should become V8ScriptValue in M37.

[Jacob, 2014-06-03 20:23:14]

PTAL

https://chromiumcodereview.appspot.com/300393002/diff/20001/LayoutTests/dart/...
File LayoutTests/dart/inspector/evaluate-in-console.html (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/LayoutTests/dart/...
LayoutTests/dart/inspector/evaluate-in-console.html:86: // dartbug.com/18646 is
fixed.
On 2014/06/03 14:24:49, vsm wrote:
> This is marked fixed now.  Re-enable?

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
File Source/bindings/common/ScriptValue.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:217: {
On 2014/06/03 14:24:49, vsm wrote:
> ASSERT(m_isJavaScript) ?

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:222: {
On 2014/06/03 14:24:49, vsm wrote:
> ASSERT(!m_isJavaScript) ?

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:233: ScriptValue m_scriptValue;
On 2014/06/03 17:32:34, rmacnak wrote:
> RefPtr<V8ScriptValue>

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:262: Dart_ActivationFrame asDart() const {
return m_dartActivationFrame; }
On 2014/06/03 14:24:49, vsm wrote:
> Ditto on asserts for these two.

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/c...
Source/bindings/common/ScriptValue.h:266: ScriptValue m_scriptValue;
On 2014/06/03 17:32:34, rmacnak wrote:
> RefPtr<V8ScriptValue>

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartController.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartController.cpp:208: if (isDebuggerEnabled) {
On 2014/06/03 14:24:49, vsm wrote:
> When is this enabled?  I seem to hit this path regardless of whether devtools
is
> open.

I believe the flag is always true unless you start chrome with a flag to disable
it. As a separate CL we need to fix things so we don't register isolates until
the devtools / remote devtools connection is actually open. That said, the tax
for registering isolates will be much lower now that we don't need to parse a V8
script as part of the call to DartDebugServer/DartScriptDebugServer.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:128: Dart_Handle
findThisVariable(Dart_Handle locals)
On 2014/06/03 17:32:34, rmacnak wrote:
> findReceiver

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:128: Dart_Handle
findThisVariable(Dart_Handle locals)
On 2014/06/03 17:32:34, rmacnak wrote:
> findReceiver

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:132: ASSERT(!Dart_IsError(result));
On 2014/06/03 14:24:49, vsm wrote:
> ASSERT(length % 2 == 0);

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:49: enum Type {
On 2014/06/03 14:24:49, vsm wrote:
> Consider "Kind".

That is better. Switched it here and elsewhere in this file.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:51: ObjectClass,
On 2014/06/03 14:24:49, vsm wrote:
> What's the difference between ObjectClass, Class, and StaticClass below?

I'll add a FIXME.  Having those three kinds is a bit ugly. The issue is we want
to render the same Dart_Handle differently in the DevTools depending on the
context.
For example, given a handle to a Dart Type, we want to display its static
members if the DartDebuggerObject is tagged as StaticClass.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:63:
DartDebuggerObject(Dart_PersistentHandle, const String& objectGroup, Type);
On 2014/06/03 14:24:49, vsm wrote:
> What is objectGroup here?  We use the term for GC - is this something similar?

this is just the devtools notion of an object group which is something much more
trivial. it is just a set of handles that can be freed as a group. I use the
term because it is what is also used in the V8 InjectedScript code.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:71: Dart_PersistentHandle m_handle;
On 2014/06/03 14:24:49, vsm wrote:
> Free handle in destructor?

good catch. done. cleaned up DartDebuggerObject free logic.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:187: typedef HashMap<String,
DartDebuggerObject*> DebuggerObjectMap;
On 2014/06/03 14:24:49, vsm wrote:
> Unless these two maps can have NULL values, probably better off eliminating
the
> pointer.  E.g.,
> 
> typedef HashMap<String, Vector<String> >

eliminated the ptr from ObjectGroupMap.
DartDebuggerObjectMap would need to switch to refcounting (probably not a bad
idea) as otherwise we would free the persistent handles on HashMap resize.
Added FIXME to switch DebuggerObjectMap to use RefPtr.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartScriptDebugServer.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartScriptDebugServer.cpp:361: // FIXME: we can get rid of
the V8Scope once DartScriptState and
On 2014/06/03 17:32:34, rmacnak wrote:
> Can we remove this now?

sadly we can't yet. I updated the comment. with some future cleanup we can get
rid of it but the code inside DartController that this calls still has to go
through V8 to get the v8ScriptState. If we clean it up we should be able to
remove this ugly extra V8Scope call but I'd like to do that as a separate CL as
it is not trivial.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartScriptDebugServer.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartScriptDebugServer.h:57: {
On 2014/06/03 14:24:49, vsm wrote:
> Do you want to assert whether the value is already present?

This helper class was just copied from the old DartDebugServer.cpp but I agree
this is wrong so I fixed it. Added the assert though as it seems odd not to have
one here.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartUtilities.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartUtilities.h:223: static ScriptState*
v8ScriptStateForCurrentIsolate();
On 2014/06/03 17:32:34, rmacnak wrote:
> V8ScriptState

Done.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
File Source/core/inspector/InjectedScriptBase.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
Source/core/inspector/InjectedScriptBase.h:58: class V8InjectedScriptBase :
public virtual InjectedScriptBase {
On 2014/06/03 14:24:49, vsm wrote:
> The virtual base class feels kind of nasty.  Not sure I've seen it in blink
code
> either.
> 
> Is InjectedScriptBase an instantiated class?  If not, maybe this could be
folded
> into V8InjectedScript.

This is ugly. Added a FIXMEDart that we need to find a better solution before
upstreaming.
I feel there is a cleaner way to do it but I haven't figured it out yet.
InjectedScriptBase isn't instantiated so I suspect the best thing to do is to
just make this V8InjectedScriptBaseUtil
and call it from the two V8 classes that subclass this.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/core/inspe...
Source/core/inspector/InjectedScriptBase.h:85: ScriptObject
m_injectedScriptObject;
On 2014/06/03 17:32:34, rmacnak wrote:
> Add a note this should become V8ScriptValue in M37.

done.

[rmacnak, 2014-06-03 22:28:08]

This doesn't patch in tip-of-tree.

https://chromiumcodereview.appspot.com/300393002/diff/40001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/40001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:316: Dart_Handle
wrappedExpressionArgs = Dart_ListGetAt(wrappedExpressionTuple, 1);
Add a TODO to replace this business of wrapping locals with
Dart_ActivationFrameEvaluate.

[Jacob, 2014-06-03 23:13:41]

https://chromiumcodereview.appspot.com/300393002/diff/40001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/40001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:316: Dart_Handle
wrappedExpressionArgs = Dart_ListGetAt(wrappedExpressionTuple, 1);
On 2014/06/03 22:28:07, rmacnak wrote:
> Add a TODO to replace this business of wrapping locals with
> Dart_ActivationFrameEvaluate.

Done.

[rmacnak, 2014-06-04 00:45:14]

LGTM if StackTrace and ActivationFrame get pulled into a separate file.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:580:
remoteObject->setClassName("Dart Libraries");
"Dart Isolate"?

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.h (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.h:58: Libraries,
Isolate?

[Jacob, 2014-06-04 01:14:52]

Committed patchset #5 manually as r175418 (presubmit successful).

[Jacob, 2014-06-04 01:21:41]

vsm, feel free to send additional comments tonight and I'll apply them in the
AM.
Moved StackTrace out into a separate file.

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartInjectedScript.cpp (right):

https://chromiumcodereview.appspot.com/300393002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartInjectedScript.cpp:580:
remoteObject->setClassName("Dart Libraries");
On 2014/06/04 00:45:13, rmacnak wrote:
> "Dart Isolate"?
Good idea. Changed this name to Dart Isolate and renamed the kind for Libraries
to Isolate.