Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Unified Diff: Source/core/inspector/InjectedScriptManager.h

Issue 300393002: Merge DevTools Refactor CL to Blink36 (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/1985
Patch Set: PTAL Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InjectedScriptHost.cpp ('k') | Source/core/inspector/InjectedScriptManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InjectedScriptManager.h
diff --git a/Source/core/inspector/InjectedScriptManager.h b/Source/core/inspector/InjectedScriptManager.h
index 8472b0ad4503d4960d49d0ee8cab547f92e8bcb5..8c49b621b6649e6f5c691fae0ca4819276bceb19 100644
--- a/Source/core/inspector/InjectedScriptManager.h
+++ b/Source/core/inspector/InjectedScriptManager.h
@@ -40,6 +40,7 @@ namespace WebCore {
class DOMWindow;
class InjectedScript;
+class V8InjectedScript;
class InjectedScriptHost;
class ScriptObject;
@@ -54,10 +55,10 @@ public:
InjectedScriptHost* injectedScriptHost();
- InjectedScript injectedScriptFor(ScriptState*);
- InjectedScript injectedScriptForId(int);
+ InjectedScript& injectedScriptFor(ScriptState*);
+ InjectedScript& injectedScriptForId(int);
int injectedScriptIdFor(ScriptState*);
- InjectedScript injectedScriptForObjectId(const String& objectId);
+ InjectedScript& injectedScriptForObjectId(const String& objectId);
void discardInjectedScripts();
void discardInjectedScriptsFor(DOMWindow*);
void releaseObjectGroup(const String& objectGroup);
@@ -67,6 +68,8 @@ public:
struct CallbackData;
static void setWeakCallback(const v8::WeakCallbackData<v8::Object, CallbackData>&);
+
+ InjectedScript& placeholderInjectedScript();
private:
explicit InjectedScriptManager(InspectedStateAccessCheck);
@@ -77,12 +80,14 @@ private:
static bool canAccessInspectedWorkerGlobalScope(ScriptState*);
int m_nextInjectedScriptId;
- typedef HashMap<int, InjectedScript> IdToInjectedScriptMap;
+ // FIXMEDART: use RefPtr<InjectedScript> instead.
+ typedef HashMap<int, InjectedScript*> IdToInjectedScriptMap;
IdToInjectedScriptMap m_idToInjectedScript;
RefPtr<InjectedScriptHost> m_injectedScriptHost;
InspectedStateAccessCheck m_inspectedStateAccessCheck;
typedef HashMap<RefPtr<ScriptState>, int> ScriptStateToId;
ScriptStateToId m_scriptStateToId;
+ V8InjectedScript* m_placeholderInjectedScript;
};
} // namespace WebCore
« no previous file with comments | « Source/core/inspector/InjectedScriptHost.cpp ('k') | Source/core/inspector/InjectedScriptManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698