Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: Source/devtools/front_end/sdk/DebuggerModel.js

Issue 300393002: Merge DevTools Refactor CL to Blink36 (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/1985
Patch Set: PTAL Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/Source/devtools/front_end/sdk/DebuggerModel.js b/Source/devtools/front_end/sdk/DebuggerModel.js
index 4dfe20c3564a32612197eb0260060737f3864ba7..acd68fc4b567b8384c5aca088cb5a034a5ae7f75 100644
--- a/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -590,39 +590,6 @@ WebInspector.DebuggerModel.prototype = {
},
/**
- * @param {function(!Object)} callback
- */
- getSelectedCallFrameVariables: function(callback)
- {
- var result = { this: true };
-
- var selectedCallFrame = this._selectedCallFrame;
- if (!selectedCallFrame)
- callback(result);
-
- var pendingRequests = 0;
-
- function propertiesCollected(properties)
- {
- for (var i = 0; properties && i < properties.length; ++i)
- result[properties[i].name] = true;
- if (--pendingRequests == 0)
- callback(result);
- }
-
- for (var i = 0; i < selectedCallFrame.scopeChain.length; ++i) {
- var scope = selectedCallFrame.scopeChain[i];
- // FIXMEDART: find a cleaner way of avoiding completing to all
- // library names.
- if (scope.type == "library")
- continue;
- var object = this.target().runtimeModel.createRemoteObject(scope.object);
- pendingRequests++;
- object.getAllProperties(false, propertiesCollected);
- }
- },
-
- /**
* @param {boolean} active
*/
setBreakpointsActive: function(active)
@@ -1008,6 +975,12 @@ WebInspector.DebuggerModel.CallFrame.prototype = {
this._debuggerAgent.evaluateOnCallFrame(this._payload.callFrameId, code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEvaluateOnCallFrame);
},
+ /* XXX add doccomment. */
+ getCompletions: function(code, callback)
+ {
+ this._debuggerAgent.getCompletionsOnCallFrame(this._payload.callFrameId, code, callback);
+ },
+
/**
* @param {function(?Protocol.Error=)=} callback
*/
« no previous file with comments | « Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | Source/devtools/front_end/sdk/RemoteObject.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698