[hunspell] Fix read from uninit memory.

[hunspell] Fix read from uninit memory.

BUG=377728
R=avi@chromium.org, rlp@chromium.org
TBR=darin@chromium.org

Committed: 273952

[groby-ooo-7-16, 2014-05-27 18:44:54]

rlp: Sorry, uploaded to wrong codereview :(
darin: TBR

[rpetterson, 2014-05-27 19:11:41]

lgtm

[groby-ooo-7-16, 2014-05-27 19:13:00]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:15:12]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Avi (use Gerrit), 2014-05-27 20:04:04]

nope.

https://codereview.chromium.org/300233002/diff/1/src/hunspell/suggestmgr.cxx
File src/hunspell/suggestmgr.cxx (right):

https://codereview.chromium.org/300233002/diff/1/src/hunspell/suggestmgr.cxx#...
src/hunspell/suggestmgr.cxx:2112: b = (char *) calloc((m + 1) * (n + 1));
No, calloc doesn't work that way. calloc takes two parameters.

Do:

c = (char *)calloc(m + 1, n + 1);
b = // ditto

[Avi (use Gerrit), 2014-05-27 20:05:42]

not lgtm

this won't compile.

[Avi (use Gerrit), 2014-05-27 20:11:40]

https://codereview.chromium.org/300233002/diff/1/src/hunspell/suggestmgr.cxx
File src/hunspell/suggestmgr.cxx (right):

https://codereview.chromium.org/300233002/diff/1/src/hunspell/suggestmgr.cxx#...
src/hunspell/suggestmgr.cxx:2120: for (j = 0; j <= n; j++) c[j] = 0;
Weren't you also going to delete these two magical lines? They're not needed
with calloc.

[groby-ooo-7-16, 2014-05-27 20:34:41]

Lost in a maze of patch directories, all alike. Actual version uploaded.
PTAL

[groby-ooo-7-16, 2014-05-27 20:36:44]

Also with amended instructions, hopefully a bit clearer.

[Avi (use Gerrit), 2014-05-27 20:40:48]

LGTM with nit.

Did you update the upstream patch? That one was wrong too.

https://codereview.chromium.org/300233002/diff/40001/src/hunspell/suggestmgr.cxx
File src/hunspell/suggestmgr.cxx (right):

https://codereview.chromium.org/300233002/diff/40001/src/hunspell/suggestmgr....
src/hunspell/suggestmgr.cxx:2112: b = (char *) calloc((m + 1), (n + 1));
The parentheses around m+1 and n+1 aren't necessary.

[groby-ooo-7-16, 2014-05-29 01:43:53]

Fixed - holding back on the commit for a second or three since it _might_ be a
false positive from DrMemory. Investigation (hopefully) on bug.

[groby-ooo-7-16, 2014-05-30 17:05:52]

It's a correct leak indication, caused by a compiler bug. Landing, since this
patch at least removes the code that causes the invalid code generation.

[groby-ooo-7-16, 2014-05-30 17:05:57]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-05-30 17:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 17:06:12]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[groby-ooo-7-16, 2014-05-31 00:11:53]

Committed patchset #4 manually as r273952 (presubmit successful).