[hunspell] Fix read from uninit memory.

src/hunspell/suggestmgr.cxx

 #include "license.hunspell"
 #include "license.myspell"
 
 #include <stdlib.h> 
 #include <string.h>
 #include <stdio.h> 
 #include <ctype.h>
 
 #include "suggestmgr.hxx"
 #include "htypes.hxx"
@@ skipping 2090 matching lines @@
   char * c;
   int i;
   int j;
   if (utf8) {
     m = u8_u16(su, MAXSWL, s);
     n = u8_u16(su2, MAXSWL, s2);
   } else {
     m = strlen(s);
     n = strlen(s2);
   }
-  c = (char *) malloc((m + 1) * (n + 1));
-  b = (char *) malloc((m + 1) * (n + 1));
+  c = (char *) calloc((m + 1), (n + 1));
+  b = (char *) calloc((m + 1), (n + 1));

[Avi (use Gerrit), 2014/05/27 20:40:49]

The parentheses around m+1 and n+1 aren't necessary.

   if (!c || !b) {
     if (c) free(c);
     if (b) free(b);
     *result = NULL;
     return;
   }
-  for (i = 1; i <= m; i++) c[i*(n+1)] = 0;
-  for (j = 0; j <= n; j++) c[j] = 0;
   for (i = 1; i <= m; i++) {
     for (j = 1; j <= n; j++) {
       if ( ((utf8) && (*((short *) su+i-1) == *((short *)su2+j-1)))
           || ((!utf8) && ((*(s+i-1)) == (*(s2+j-1))))) {
         c[i*(n+1) + j] = c[(i-1)*(n+1) + j-1]+1;
         b[i*(n+1) + j] = LCS_UPLEFT;
       } else if (c[(i-1)*(n+1) + j] >= c[i*(n+1) + j-1]) {
         c[i*(n+1) + j] = c[(i-1)*(n+1) + j];
         b[i*(n+1) + j] = LCS_UP;
       } else {
@@ skipping 24 matching lines @@
       len++;
       i--;
       j--;
     } else if (result[i*(n+1) + j] == LCS_UP) {
       i--;
     } else j--;
   }
   free(result);
   return len;
 }