Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: README.chromium

Issue 300233002: [hunspell] Fix read from uninit memory. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/hunspell.git@master
Patch Set: Fix nit. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | google.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name: hunspell 1 Name: hunspell
2 URL: http://hunspell.sourceforge.net/ 2 URL: http://hunspell.sourceforge.net/
3 Version: 1.3.2 3 Version: 1.3.2
4 License: MPL 1.1/GPL 2.0/LGPL 2.1 4 License: MPL 1.1/GPL 2.0/LGPL 2.1
5 License File: COPYING 5 License File: COPYING
6 Security Critical: yes 6 Security Critical: yes
7 7
8 Description: 8 Description:
9 This is a partial copy of Hunspell 1.3.2 with the following changes: 9 This is a partial copy of Hunspell 1.3.2 with the following changes:
10 * Remove '#include "config.h"' from src/hunspell/hunspell.hxx 10 * Remove '#include "config.h"' from src/hunspell/hunspell.hxx
11 * Remove '#include "config.h"' from src/hunspell/license.hunspell 11 * Remove '#include "config.h"' from src/hunspell/license.hunspell
12 * Change src/hunspell/filemgr.hxx and src/hunspell/filemgr.cxx to use 12 * Change src/hunspell/filemgr.hxx and src/hunspell/filemgr.cxx to use
13 LineIterator. 13 LineIterator.
14 * Add ScopedHashEntry, which creates temporary hentry objects, to 14 * Add ScopedHashEntry, which creates temporary hentry objects, to
15 src/hunspell/suggestmgr.cxx 15 src/hunspell/suggestmgr.cxx
16 * Change the input params of the constructors to receive a BDICTReader instead 16 * Change the input params of the constructors to receive a BDICTReader instead
17 of a file path. 17 of a file path.
18 * Merge http://hunspell.cvs.sourceforge.net/viewvc/hunspell/hunspell/src/hunspel l/affixmgr.cxx?r1=1.40&r2=1.41 18 * Merge http://hunspell.cvs.sourceforge.net/viewvc/hunspell/hunspell/src/hunspel l/affixmgr.cxx?r1=1.40&r2=1.41
19 The patch is in google.patch. 19 The patch is in google.patch.
20 * Add a pointer to the bdict_reader into the "SuggestMgr" so that it can use the 20 * Add a pointer to the bdict_reader into the "SuggestMgr" so that it can use the
21 replacement table from the bdict file for the secondary suggestion mechanism. 21 replacement table from the bdict file for the secondary suggestion mechanism.
22 * Avoid crash in SuggestMgr::forgotchar_utf() and SuggestMgr::forgotchar() on 22 * Avoid crash in SuggestMgr::forgotchar_utf() and SuggestMgr::forgotchar() on
23 Windows by using a one-character larger buffer. 23 Windows by using a one-character larger buffer.
24 * calloc buffers in SuggestMgr::lcs to avoid reads from uninintialized buffers.
24 25
25 Chromium-specific changes are in google.patch. To update the patch, follow these 26 Chromium-specific changes are in google.patch. To update the patch, follow these
26 steps: 27 steps:
27 1) Checkout hunspell: 28 1) Checkout hunspell:
28 $ cvs -z3 \ 29 $ cvs -z3 \
29 -d:pserver:anonymous@hunspell.cvs.sourceforge.net:/cvsroot/hunspell \ 30 -d:pserver:anonymous@hunspell.cvs.sourceforge.net:/cvsroot/hunspell \
30 co -D "23 Mar 2012" -P hunspell 31 co -D "23 Mar 2012" -P hunspell
31 2) Apply the existing patch: 32 2) Apply the existing patch:
32 $ cd hunspell 33 $ cd hunspell
33 $ patch -p0 -i ~/src/third_party/hunspell/google.patch 34 $ patch -p0 -i ~/src/third_party/hunspell/google.patch
34 3) Make your new changes. 35 3) Make your new changes inside the CVS hunspell directory.
35 4) Generate the updated patch: 36 4) Generate the updated patch:
36 $ cvs diff -u > ~/src/third_party/hunspell/google.patch 37 $ cvs diff -u > ~/src/third_party/hunspell/google.patch
37 38
38 All dictionaries used by Chromium has been checked in to the 39 All dictionaries used by Chromium has been checked in to the
39 'third_party/hunspell_dictionaries' directory. They have several additions over 40 'third_party/hunspell_dictionaries' directory. They have several additions over
40 the default myspell/hunspell dictionaries. 41 the default myspell/hunspell dictionaries.
41 (See 'third_party/hunspell_dictionaries/README.chromium' for their details.) 42 (See 'third_party/hunspell_dictionaries/README.chromium' for their details.)
OLDNEW
« no previous file with comments | « no previous file | google.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698