Make package:kernel's verifier pass fasta-compiled code, make fasta not return exitcode 1 for warni…

Make package:kernel's verifier pass fasta-compiled code, make fasta not return exitcode 1 for warnings

[kustermann, 2017-08-21 12:52:18]

kustermann@google.com changed reviewers:
+ ahe@google.com

[kustermann, 2017-08-21 12:52:19]

Because we talked about it offline and you discovered the root cause of the
'exitcode == 1' issue, I suspect there's a reason why this hasn't been fixed
yet.

So I'm just sending this CL out to get feedback on how to get it fixed (also in
order to get an URL to point to).

These 2 changes are required for another CL.

[ahe, 2017-08-21 13:48:33]

ahe@google.com changed reviewers:
+ sigmund@google.com

[ahe, 2017-08-21 13:48:33]

I discussed this with Siggi Thursday night and I distinctly remember this was
more complicated than just this fix.

https://codereview.chromium.org/3002053002/diff/1/pkg/kernel/lib/verifier.dart
File pkg/kernel/lib/verifier.dart (right):

https://codereview.chromium.org/3002053002/diff/1/pkg/kernel/lib/verifier.dar...
pkg/kernel/lib/verifier.dart:374: if (!node.target.hasGetter && node.target is!
Constructor) {
Can you show provide me with an example of how this happens? Normally, we
override the verifier behavior for fasta specific stuff in
pkg/front_end/lib/src/fasta/kernel/verifier.dart.

[kustermann, 2017-08-21 14:43:44]

https://codereview.chromium.org/3002053002/diff/1/pkg/kernel/lib/verifier.dart
File pkg/kernel/lib/verifier.dart (right):

https://codereview.chromium.org/3002053002/diff/1/pkg/kernel/lib/verifier.dar...
pkg/kernel/lib/verifier.dart:374: if (!node.target.hasGetter && node.target is!
Constructor) {
On 2017/08/21 13:48:33, ahe wrote:
> Can you show provide me with an example of how this happens? Normally, we
> override the verifier behavior for fasta specific stuff in
> pkg/front_end/lib/src/fasta/kernel/verifier.dart.

Followed Peter's recommendation offline and commented on the corresponding
github issue (https://github.com/dart-lang/sdk/issues/29841).

Basically `package:kernel/verifier.dart` (which is used e.g. by
`pkg/kernel/bin/transform.dart`) barfs on these redirecting factory bodies (as
does a constants transformer I worked on)

[Siggi Cherem (dart-lang), 2017-08-21 20:01:51]

the change in compiler_command_line lgtm, I defer to Peter or Kevin on what to
do about the Verifier, but I'm not opposed to your suggestion here.

We need to do some additional follow up work to get rid of uses of `exitCode`
elsewhere in fasta, but I'm fine doing that as a follow up.

https://codereview.chromium.org/3002053002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/compiler_command_line.dart (right):

https://codereview.chromium.org/3002053002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/compiler_command_line.dart:163:
..setExitCodeOnProblem = false
since the default is false, let's simply delete this line