Make package:kernel's verifier pass fasta-compiled code, make fasta not return exitcode 1 for warni…

pkg/kernel/lib/verifier.dart

Index: pkg/kernel/lib/verifier.dart
diff --git a/pkg/kernel/lib/verifier.dart b/pkg/kernel/lib/verifier.dart
index c923a8d7d8ae63fa57ba91655b87a83eda949e60..b81f09ac1d6d960211e816f30fb4ebb1b044c0f1 100644
--- a/pkg/kernel/lib/verifier.dart
+++ b/pkg/kernel/lib/verifier.dart
@@ -363,7 +363,15 @@ class VerifyingVisitor extends RecursiveVisitor {
     if (node.target == null) {
       problem(node, "StaticGet without target.");
     }
-    if (!node.target.hasGetter) {
+    // Currently Constructor.hasGetter returns `false` even though fasta uses it
+    // as a getter for internal purposes:
+    //
+    // Fasta is letting all call site of a redirecting constructor be resolved
+    // to the real target.  In order to resolve it, it seems to add a body into
+    // the redirecting-factory constructor which caches the target constructor.
+    // That cache is via a `StaticGet(real-constructor)` node, which we make
+    // here pass the verifier.
+    if (!node.target.hasGetter && node.target is! Constructor) {

[ahe, 2017/08/21 13:48:33]

Can you show provide me with an example of how this happens? Normally, we
override the verifier behavior for fasta specific stuff in
pkg/front_end/lib/src/fasta/kernel/verifier.dart.

[kustermann, 2017/08/21 14:43:44]

Followed Peter's recommendation offline and commented on the corresponding
github issue (https://github.com/dart-lang/sdk/issues/29841).

Basically `package:kernel/verifier.dart` (which is used e.g. by
`pkg/kernel/bin/transform.dart`) barfs on these redirecting factory bodies (as
does a constants transformer I worked on)

       problem(node, "StaticGet of '${node.target}' without getter.");
     }
     if (node.target.isInstanceMember) {