Make package:kernel's verifier pass fasta-compiled code, make fasta not return exitcode 1 for warni…

pkg/kernel/lib/verifier.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library kernel.checks;
 
 import 'ast.dart';
 import 'transformations/flags.dart';
 
 void verifyProgram(Program program) {
   VerifyingVisitor.check(program);
@@ skipping 345 matching lines @@
     checkVariableInScope(node.variable, node);
     visitChildren(node);
   }
 
   @override
   visitStaticGet(StaticGet node) {
     visitChildren(node);
     if (node.target == null) {
       problem(node, "StaticGet without target.");
     }
-    if (!node.target.hasGetter) {
+    // Currently Constructor.hasGetter returns `false` even though fasta uses it
+    // as a getter for internal purposes:
+    //
+    // Fasta is letting all call site of a redirecting constructor be resolved
+    // to the real target.  In order to resolve it, it seems to add a body into
+    // the redirecting-factory constructor which caches the target constructor.
+    // That cache is via a `StaticGet(real-constructor)` node, which we make
+    // here pass the verifier.
+    if (!node.target.hasGetter && node.target is! Constructor) {

[ahe, 2017/08/21 13:48:33]

Can you show provide me with an example of how this happens? Normally, we
override the verifier behavior for fasta specific stuff in
pkg/front_end/lib/src/fasta/kernel/verifier.dart.

[kustermann, 2017/08/21 14:43:44]

Followed Peter's recommendation offline and commented on the corresponding
github issue (https://github.com/dart-lang/sdk/issues/29841).

Basically `package:kernel/verifier.dart` (which is used e.g. by
`pkg/kernel/bin/transform.dart`) barfs on these redirecting factory bodies (as
does a constants transformer I worked on)

       problem(node, "StaticGet of '${node.target}' without getter.");
     }
     if (node.target.isInstanceMember) {
       problem(node, "StaticGet of '${node.target}' that's an instance member.");
     }
   }
 
   @override
   visitStaticSet(StaticSet node) {
     visitChildren(node);
@@ skipping 224 matching lines @@
     var oldParent = parent;
     parent = node;
     node.visitChildren(this);
     parent = oldParent;
   }
 }
 
 void checkInitializers(Constructor constructor) {
   // TODO(ahe): I'll add more here in other CLs.
 }