Make package:kernel's verifier pass fasta-compiled code, make fasta not return exitcode 1 for warni…

pkg/front_end/lib/src/fasta/compiler_command_line.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.compiler_command_line;
 
 import 'dart:io' show exit;
 
 import 'package:kernel/target/targets.dart'
     show Target, getTarget, TargetFlags, targets;
@@ skipping 142 matching lines @@
       ..packagesFileUri = cl.packages
       ..strongMode = cl.strongMode
       ..target = cl.target
       ..throwOnErrors = cl.errorsAreFatal
       ..throwOnWarnings = cl.warningsAreFatal
       ..throwOnNits = cl.nitsAreFatal
       ..embedSourceText = !cl.excludeSource
       // All command-line tools take only a single entry point and chase
       // dependencies, and provide a non-zero exit code when errors are found.
       ..chaseDependencies = true
-      ..setExitCodeOnProblem = true
+      ..setExitCodeOnProblem = false

[Siggi Cherem (dart-lang), 2017/08/21 20:01:51]

since the default is false, let's simply delete this line

       ..debugDump = cl.dumpIr
       ..verbose = cl.verbose
       ..verify = cl.verify;
 
     var inputs = <Uri>[];
     if (areRestArgumentsInputs) {
       inputs = cl.arguments.map(Uri.base.resolve).toList();
     }
     var pOptions = new ProcessedOptions(options, false, inputs, cl.output);
     return CompilerContext.runWithOptions(pOptions, (c) => f(c, cl.arguments));
@@ skipping 28 matching lines @@
   StringBuffer sb = new StringBuffer(basicUsage);
   if (summary != null) {
     sb.writeln();
     sb.writeln(summary);
     sb.writeln();
   }
   sb.write(options);
   // TODO(ahe): Don't use [templateUnspecified].
   return templateUnspecified.withArguments("$sb");
 }