1. Figure out the modified libraries from the specifeid kernel file during

1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case https://github.com/dart-lang/sdk/issues/30322

3. Fix crash in test that was being skipped in https://github.com/dart-lang/sdk/issues/30109 and turn that test on.

This CL is work towards completing issue https://github.com/dart-lang/sdk/issues/28051

R=aam@google.com

Committed: https://github.com/dart-lang/sdk/commit/cfac48179bd9ad092688503bcaf0431c0c0733fd

[siva, 2017-08-17 16:32:52]

Description was changed from

==========
1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case

This fix is for issue https://github.com/dart-lang/sdk/issues/28051
==========

to

==========
1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case
https://github.com/dart-lang/sdk/issues/30322

This fix is related to issue https://github.com/dart-lang/sdk/issues/28051
==========

[siva, 2017-08-17 16:33:34]

Description was changed from

==========
1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case
https://github.com/dart-lang/sdk/issues/30322

This fix is related to issue https://github.com/dart-lang/sdk/issues/28051
==========

to

==========
1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case
https://github.com/dart-lang/sdk/issues/30322

This CL is work towards completing issue
https://github.com/dart-lang/sdk/issues/28051
==========

[siva, 2017-08-18 00:14:14]

Description was changed from

==========
1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case
https://github.com/dart-lang/sdk/issues/30322

This CL is work towards completing issue
https://github.com/dart-lang/sdk/issues/28051
==========

to

==========
1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case
https://github.com/dart-lang/sdk/issues/30322

3. Fix crash in test that was being skipped in
https://github.com/dart-lang/sdk/issues/30109 and turn that test on.

This CL is work towards completing issue
https://github.com/dart-lang/sdk/issues/28051
==========

[siva, 2017-08-18 00:20:53]

asiva@google.com changed reviewers:
+ aam@google.com, sigmund@google.com

[aam, 2017-08-18 16:04:20]

awesome, lgtm!

https://codereview.chromium.org/2998983002/diff/40001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2998983002/diff/40001/runtime/include/dart_ap...
runtime/include/dart_api.h:2722: Dart_kKernelTag,
Can we please add a description of this tag in the comments below?

https://codereview.chromium.org/2998983002/diff/40001/runtime/vm/isolate_relo...
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2998983002/diff/40001/runtime/vm/isolate_relo...
runtime/vm/isolate_reload.cc:577: if (result.IsError()) {
Can this section be moved up to line 560?
IOTW, is the only way for `result.IsError()` to be true here when
`Dart_IsError(retval)` was true up at line 557?

https://codereview.chromium.org/2998983002/diff/40001/runtime/vm/isolate_relo...
runtime/vm/isolate_reload.cc:730: if (reload_skipped_ || reload_finalized_) {
Do we want to return when reload_finalized_ == true only if
isolate()->use_dart_frontend() ?

[siva, 2017-08-18 17:17:51]

https://codereview.chromium.org/2998983002/diff/40001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2998983002/diff/40001/runtime/include/dart_ap...
runtime/include/dart_api.h:2722: Dart_kKernelTag,
On 2017/08/18 16:04:20, aam wrote:
> Can we please add a description of this tag in the comments below?

Done.

https://codereview.chromium.org/2998983002/diff/40001/runtime/vm/isolate_relo...
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2998983002/diff/40001/runtime/vm/isolate_relo...
runtime/vm/isolate_reload.cc:577: if (result.IsError()) {
On 2017/08/18 16:04:20, aam wrote:
> Can this section be moved up to line 560?
> IOTW, is the only way for `result.IsError()` to be true here when
> `Dart_IsError(retval)` was true up at line 557?

The reason it is outside is because we need to run come out of the
TransitionVMToNative scope so we are back in the VM mode from Native mode before
we start processing some of the errors and rollback stuff that has been done so
far.

https://codereview.chromium.org/2998983002/diff/40001/runtime/vm/isolate_relo...
runtime/vm/isolate_reload.cc:730: if (reload_skipped_ || reload_finalized_) {
On 2017/08/18 16:04:20, aam wrote:
> Do we want to return when reload_finalized_ == true only if
> isolate()->use_dart_frontend() ?

It was asserting that reload_finalized_ should be false, so I felt it is ok to
just return if FinalizeLoading is being called multiple times even in the non
use_dart_frontend mode.

[Siggi Cherem (dart-lang), 2017-08-18 18:43:56]

very cool!

https://codereview.chromium.org/2998983002/diff/60001/pkg/front_end/test/src/...
File pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart (right):

https://codereview.chromium.org/2998983002/diff/60001/pkg/front_end/test/src/...
pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart:139: });
woo hoo!

[siva, 2017-08-18 20:42:23]

Description was changed from

==========
1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case
https://github.com/dart-lang/sdk/issues/30322

3. Fix crash in test that was being skipped in
https://github.com/dart-lang/sdk/issues/30109 and turn that test on.

This CL is work towards completing issue
https://github.com/dart-lang/sdk/issues/28051
==========

to

==========
1. Figure out the modified libraries from the specifeid kernel file during
   reload instead of computing it based on the source modification information.

2. Fix for failure in Unit test case
https://github.com/dart-lang/sdk/issues/30322

3. Fix crash in test that was being skipped in
https://github.com/dart-lang/sdk/issues/30109 and turn that test on.

This CL is work towards completing issue
https://github.com/dart-lang/sdk/issues/28051

R=aam@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cfac48179bd9ad092688503bcaf0431c0c0733fd
==========

[siva, 2017-08-18 20:42:24]

Committed patchset #4 (id:60001) manually as
cfac48179bd9ad092688503bcaf0431c0c0733fd (presubmit successful).