Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: runtime/bin/dfe.h

Issue 2998983002: 1. Figure out the modified libraries from the specifeid kernel file during (Closed)
Patch Set: Address code review comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/dfe.h
diff --git a/runtime/bin/dfe.h b/runtime/bin/dfe.h
index 8a6fcab1a23f07c7b34502640978113cd4429ecf..14913eaef761f1d96c5dd1867fb07ce886075b88 100644
--- a/runtime/bin/dfe.h
+++ b/runtime/bin/dfe.h
@@ -38,11 +38,11 @@ class DFE {
bool kernel_file_specified() const { return kernel_file_specified_; }
void set_kernel_file_specified(bool value) { kernel_file_specified_ = value; }
- // Method to reload a script into a running a isolate.
+ // Method to read a kernel file into a kernel program blob.
// If the specified script [url] is not a kernel IR, compile it first using
- // DFE and then reload the resulting kernel IR into the isolate.
+ // DFE and then read the resulting kernel file into a kernel program blob.
// Returns Dart_Null if successful, otherwise an error object is returned.
- Dart_Handle ReloadScript(Dart_Isolate isolate, const char* url_string);
+ Dart_Handle ReadKernelBinary(Dart_Isolate isolate, const char* url_string);
// Compiles a script and reads the resulting kernel file.
// If the compilation is successful, returns a valid in memory kernel

Powered by Google App Engine
This is Rietveld 408576698