Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: runtime/vm/unit_test.cc

Issue 2998983002: 1. Figure out the modified libraries from the specifeid kernel file during (Closed)
Patch Set: Address code review comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/unit_test.cc
diff --git a/runtime/vm/unit_test.cc b/runtime/vm/unit_test.cc
index 5490c6118aaec160af52ac4b4454b26bfe723c1f..3556ea3c5741dc3f24c8e5332ca870e7b201a46d 100644
--- a/runtime/vm/unit_test.cc
+++ b/runtime/vm/unit_test.cc
@@ -215,6 +215,7 @@ static Dart_Handle LibraryTagHandler(Dart_LibraryTag tag,
if (FLAG_use_dart_frontend) {
// Reload request.
+ ASSERT(tag == Dart_kKernelTag);
const char* urlstr = NULL;
Dart_Handle result = Dart_StringToCString(url, &urlstr);
if (Dart_IsError(result)) {
@@ -238,11 +239,10 @@ static Dart_Handle LibraryTagHandler(Dart_LibraryTag tag,
ASSERT(kernel_reload_key != kUnsetThreadLocalKey);
kernel_pgm =
reinterpret_cast<void*>(OSThread::GetThreadLocal(kernel_reload_key));
- ASSERT(kernel_pgm != NULL);
OSThread::SetThreadLocal(kernel_reload_key, 0);
}
- return Dart_LoadScript(url, Dart_Null(),
- reinterpret_cast<Dart_Handle>(kernel_pgm), 0, 0);
+ ASSERT(kernel_pgm != NULL);
+ return Dart_NewExternalTypedData(Dart_TypedData_kUint64, kernel_pgm, 1);
}
if (tag == Dart_kCanonicalizeUrl) {
Dart_Handle library_url = Dart_LibraryUrl(library);
« pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart ('K') | « runtime/vm/kernel_reader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698