Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: runtime/bin/dfe.cc

Issue 2998983002: 1. Figure out the modified libraries from the specifeid kernel file during (Closed)
Patch Set: Address code review comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/dfe.cc
diff --git a/runtime/bin/dfe.cc b/runtime/bin/dfe.cc
index dad6266e930d7e20d4eed17ce825c4f8299a5989..7babe5c817ce77d39ba0e5275e918d0f2842bce1 100644
--- a/runtime/bin/dfe.cc
+++ b/runtime/bin/dfe.cc
@@ -52,7 +52,8 @@ void DFE::SetKernelBinaries(const char* name) {
File::PathSeparator(), kVMServiceIOBinaryName);
}
-Dart_Handle DFE::ReloadScript(Dart_Isolate isolate, const char* url_string) {
+Dart_Handle DFE::ReadKernelBinary(Dart_Isolate isolate,
+ const char* url_string) {
ASSERT(!Dart_IsServiceIsolate(isolate) && !Dart_IsKernelIsolate(isolate));
// First check if the URL points to a Kernel IR file in which case we
// skip the compilation step and directly reload the file.
@@ -75,17 +76,7 @@ Dart_Handle DFE::ReloadScript(Dart_Isolate isolate, const char* url_string) {
}
void* kernel_program = Dart_ReadKernelBinary(kernel_ir, kernel_ir_size);
ASSERT(kernel_program != NULL);
- Dart_Handle result = Dart_LoadKernel(kernel_program);
- if (Dart_IsError(result)) {
- return result;
- }
- // Finalize loading. This will complete any futures for completed deferred
- // loads.
- result = Dart_FinalizeLoading(true);
- if (Dart_IsError(result)) {
- return result;
- }
- return Dart_Null();
+ return Dart_NewExternalTypedData(Dart_TypedData_kUint64, kernel_program, 1);
}
void* DFE::CompileAndReadScript(const char* script_uri,

Powered by Google App Engine
This is Rietveld 408576698