Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: scheduler/appengine/acl/acl.go

Issue 2998623002: scheduler ACLs: fix ACLs saving upon job config change. (Closed)
Patch Set: fix import order Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The LUCI Authors. 1 // Copyright 2017 The LUCI Authors.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 package acl 15 package acl
16 16
17 import ( 17 import (
18 "fmt" 18 "fmt"
19 "regexp" 19 "regexp"
20 "sort" 20 "sort"
21 "strings" 21 "strings"
22 22
23 "golang.org/x/net/context"
24
23 "github.com/luci/luci-go/common/data/stringset" 25 "github.com/luci/luci-go/common/data/stringset"
24 "github.com/luci/luci-go/common/errors" 26 "github.com/luci/luci-go/common/errors"
25 "github.com/luci/luci-go/common/retry/transient" 27 "github.com/luci/luci-go/common/retry/transient"
26 "github.com/luci/luci-go/scheduler/appengine/messages" 28 "github.com/luci/luci-go/scheduler/appengine/messages"
27 "github.com/luci/luci-go/server/auth" 29 "github.com/luci/luci-go/server/auth"
28 "github.com/luci/luci-go/server/auth/identity" 30 "github.com/luci/luci-go/server/auth/identity"
29 "golang.org/x/net/context"
30 ) 31 )
31 32
32 // GrantsByRole can answer questions who can READ and who OWNS the task. 33 // GrantsByRole can answer questions who can READ and who OWNS the task.
33 type GrantsByRole struct { 34 type GrantsByRole struct {
34 Owners []string `gae:",noindex"` 35 Owners []string `gae:",noindex"`
35 Readers []string `gae:",noindex"` 36 Readers []string `gae:",noindex"`
36 } 37 }
37 38
38 func (g *GrantsByRole) IsOwner(c context.Context) (bool, error) { 39 func (g *GrantsByRole) IsOwner(c context.Context) (bool, error) {
39 return hasGrant(c, g.Owners, groupsAdministrators) 40 return hasGrant(c, g.Owners, groupsAdministrators)
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 return true, nil 186 return true, nil
186 } 187 }
187 } 188 }
188 } 189 }
189 if isMember, err := auth.IsMember(c, groups...); err != nil { 190 if isMember, err := auth.IsMember(c, groups...); err != nil {
190 return false, transient.Tag.Apply(err) 191 return false, transient.Tag.Apply(err)
191 } else { 192 } else {
192 return isMember, nil 193 return isMember, nil
193 } 194 }
194 } 195 }
OLDNEW
« no previous file with comments | « no previous file | scheduler/appengine/engine/engine.go » ('j') | scheduler/appengine/engine/engine.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698