scheduler ACLs: fix ACLs saving upon job config change.

scheduler/appengine/engine/engine_test.go

 // Copyright 2015 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 86 matching lines @@
                                 Revision:  "rev1",
                                 Enabled:   true,
                                 Schedule:  "*/5 * * * * * *",
                                 State: JobState{
                                         State:     "SCHEDULED",
                                         TickNonce: 6278013164014963328,
                                         TickTime:  epoch.Add(5 * time.Second),
                                 },
                         },
                 })
+
+                // TODO(tandrii): delete and update above definition after no-ACL -> ACL transition.
+                // Simulate ACL version roll without change of project config.
+                So(e.UpdateProjectJobs(c, "abc", []catalog.Definition{
+                        {
+                                JobID:    "abc/1",
+                                Revision: "rev1",
+                                Schedule: "*/5 * * * * * *",
+                                Acls:     acl.GrantsByRole{Readers: []string{"group:r"}, Owners: []string{"groups:o"}},
+                        }}), ShouldBeNil)
+                So(allJobs(c), ShouldResemble, []Job{
+                        {
+                                JobID:     "abc/1",
+                                ProjectID: "abc",
+                                Revision:  "rev1",
+                                Enabled:   true,
+                                Acls:      acl.GrantsByRole{Readers: []string{"group:r"}, Owners: []string{"groups:o"}},
+                                Schedule:  "*/5 * * * * * *",
+                                State: JobState{
+                                        State:     "SCHEDULED",
+                                        TickNonce: 6278013164014963328,
+                                        TickTime:  epoch.Add(5 * time.Second),
+                                },
+                        },
+                })
+
                 // Enqueued timer task to launch it.
                 task := ensureOneTask(c, "timers-q")
                 So(task.Path, ShouldEqual, "/timers")
                 So(task.ETA, ShouldResemble, epoch.Add(5*time.Second))
                 tq.GetTestable(c).ResetTasks()
 
                 // Readding same job in with exact same config revision -> noop.
                 So(e.UpdateProjectJobs(c, "abc", []catalog.Definition{
                         {
                                 JobID:    "abc/1",
@@ skipping 1116 matching lines @@
 
 func ensureOneTask(c context.Context, q string) *tq.Task {
         tqt := tq.GetTestable(c)
         tasks := tqt.GetScheduledTasks()[q]
         So(len(tasks), ShouldEqual, 1)
         for _, t := range tasks {
                 return t
         }
         return nil
 }