[vm] Remove Dart_MakeExternalString and --support-externalizable-strings

[vm] Remove Dart_MakeExternalString and --support-externalizable-strings

This CL removes unused Dart API Dart_MakeExternalString, VM option
--support-externalizable-strings and underlying support for
externalizable strings from Dart VM.

R=asiva@google.com, rmacnak@google.com

Issue: https://github.com/dart-lang/sdk/issues/30474
Committed: https://github.com/dart-lang/sdk/commit/5b694c1b1ca4a17e5aad865c6c4feb391f1e2b66

[alexmarkov, 2017-08-17 22:05:22]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com, vegorov@google.com

[alexmarkov, 2017-08-17 22:05:23]

This is the 1st part of the cleanup. Tracking of effects with EffectSet will be
removed in a separate CL.

[siva, 2017-08-17 23:52:56]

LGTM

Make sure none of the deleted unit tests show up in any status files.

[rmacnak, 2017-08-18 00:07:09]

LGTM

[alexmarkov, 2017-08-18 00:48:41]

On 2017/08/17 23:52:56, siva wrote:
> Make sure none of the deleted unit tests show up in any status files.

Good catch! Updated the vm.status.

[alexmarkov, 2017-08-18 00:49:40]

Description was changed from

==========
[vm] Remove Dart_MakeExternalString and --support-externalizable-strings

This CL removes unused Dart API Dart_MakeExternalString, VM option
--support-externalizable-strings and underlying support for
externalizable strings from Dart VM.

Issue: https://github.com/dart-lang/sdk/issues/30474
==========

to

==========
[vm] Remove Dart_MakeExternalString and --support-externalizable-strings

This CL removes unused Dart API Dart_MakeExternalString, VM option
--support-externalizable-strings and underlying support for
externalizable strings from Dart VM.

R=asiva@google.com, rmacnak@google.com

Issue: https://github.com/dart-lang/sdk/issues/30474
Committed:
https://github.com/dart-lang/sdk/commit/5b694c1b1ca4a17e5aad865c6c4feb391f1e2b66
==========

[alexmarkov, 2017-08-18 00:49:41]

Committed patchset #2 (id:20001) manually as
5b694c1b1ca4a17e5aad865c6c4feb391f1e2b66 (presubmit successful).

[Vyacheslav Egorov (Google), 2017-08-18 05:50:46]

lgtm

https://codereview.chromium.org/2997173002/diff/20001/runtime/vm/redundancy_e...
File runtime/vm/redundancy_elimination.cc (right):

https://codereview.chromium.org/2997173002/diff/20001/runtime/vm/redundancy_e...
runtime/vm/redundancy_elimination.cc:31: // TODO(alexmarkov): cleanup.
I suggest using 

TODO(dartbug.com/30474) 

instead of 

TODO(alexmarkov)

Then it's easier to find outstanding tasks.

[alexmarkov, 2017-08-21 21:17:07]

https://codereview.chromium.org/2997173002/diff/20001/runtime/vm/redundancy_e...
File runtime/vm/redundancy_elimination.cc (right):

https://codereview.chromium.org/2997173002/diff/20001/runtime/vm/redundancy_e...
runtime/vm/redundancy_elimination.cc:31: // TODO(alexmarkov): cleanup.
On 2017/08/18 05:50:46, Vyacheslav Egorov (Google) wrote:
> I suggest using 
> 
> TODO(dartbug.com/30474) 
> 
> instead of 
> 
> TODO(alexmarkov)
> 
> Then it's easier to find outstanding tasks. 

Done (in the next CL).