Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: runtime/vm/object.h

Issue 2997173002: [vm] Remove Dart_MakeExternalString and --support-externalizable-strings (Closed)
Patch Set: Update vm.status Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 711320c264b0af8372580e176087ab48c961dc62..e5af5e3fc16552218f2559b407ebc375daa8b01f 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -3375,8 +3375,6 @@ class Field : public Object {
set_kind_bits(UnboxingCandidateBit::update(b, raw_ptr()->kind_bits_));
}
- static bool IsExternalizableCid(intptr_t cid);
-
enum {
kUnknownLengthOffset = -1,
kUnknownFixedLength = -1,
@@ -6930,16 +6928,6 @@ class String : public Instance {
void ToUTF8(uint8_t* utf8_array, intptr_t array_len) const;
- // Copies the string characters into the provided external array
- // and morphs the string object into an external string object.
- // The remaining unused part of the original string object is marked as
- // an Array object or a regular Object so that it can be traversed during
- // garbage collection.
- RawString* MakeExternal(void* array,
- intptr_t external_size,
- void* peer,
- Dart_PeerFinalizer cback) const;
-
// Creates a new String object from a C string that is assumed to contain
// UTF-8 encoded characters and '\0' is considered a termination character.
// TODO(7123) - Rename this to FromCString(....).

Powered by Google App Engine
This is Rietveld 408576698