Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: runtime/include/dart_api.h

Issue 2997173002: [vm] Remove Dart_MakeExternalString and --support-externalizable-strings (Closed)
Patch Set: Update vm.status Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/tests/vm/vm.status » ('j') | runtime/vm/redundancy_elimination.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index c77c7b08331e5ee61368b21f6015f8a2dc30a4f2..4c1d2e3a8114325151c3897fb685c54de8df2823 100644
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -1833,39 +1833,6 @@ DART_EXPORT Dart_Handle Dart_StringToUTF16(Dart_Handle str,
*/
DART_EXPORT Dart_Handle Dart_StringStorageSize(Dart_Handle str, intptr_t* size);
-/**
- * Converts a String into an ExternalString.
- * The original object is morphed into an external string object.
- *
- * \param array External space into which the string data will be
- * copied into. This must not move.
- * \param external_allocation_size The size in bytes of the provided external
- * space (array). Used to inform the garbage collector.
- * \param peer An external pointer to associate with this string.
- * \param cback A callback to be called when this string is finalized.
- *
- * \return the converted ExternalString object if no error occurs.
- * Otherwise returns an error handle.
- * If the object is a valid string but if it cannot be externalized
- * the string data is copied into the external space specified
- * and the passed in peer is setup as a peer for this string object.
- * In this case the function returns the original String object as is.
- *
- * For example:
- * intptr_t size;
- * Dart_Handle result;
- * result = DartStringStorageSize(str, &size);
- * void* data = malloc(size);
- * result = Dart_MakeExternalString(str, data, size, NULL, NULL);
- *
- */
-DART_EXPORT Dart_Handle
-Dart_MakeExternalString(Dart_Handle str,
- void* array,
- intptr_t external_allocation_size,
- void* peer,
- Dart_PeerFinalizer cback);
-
/**
* Retrieves some properties associated with a String.
* Properties retrieved are:
« no previous file with comments | « no previous file | runtime/tests/vm/vm.status » ('j') | runtime/vm/redundancy_elimination.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698