Issue 2996783002: Don't record dependencies in SummaryDataStore.

Issue 2996783002: Don't record dependencies in SummaryDataStore. (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't record dependencies in SummaryDataStore. It was added for DDC, but DDC does not use it anymore. At the same time, URIs operations are expensive, and this code is showing in Observatory. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5b29ae48adcadc6f5f98c6ee937d4bb7c8414c83

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -87 lines)			Patch
M	pkg/analyzer/lib/src/summary/package_bundle_reader.dart	View	4 chunks	+3 lines, -41 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/linker_test.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/package_bundle_reader_test.dart	View	6 chunks	+4 lines, -22 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summarize_ast_test.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/build_mode.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/compiler.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/web/web_command.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 4 months ago (2017-08-10 00:45:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5b29ae48adcadc6f5f98c6ee937d4bb7c8414c83 (presubmit successful).