Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/analyzer/test/src/summary/package_bundle_reader_test.dart

Issue 2996783002: Don't record dependencies in SummaryDataStore. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/package_bundle_reader_test.dart
diff --git a/pkg/analyzer/test/src/summary/package_bundle_reader_test.dart b/pkg/analyzer/test/src/summary/package_bundle_reader_test.dart
index 6f76030feae6af7e9a0242ad20dbd781557200b0..73266b957286234db50a47c71ae669ff0831ec0b 100644
--- a/pkg/analyzer/test/src/summary/package_bundle_reader_test.dart
+++ b/pkg/analyzer/test/src/summary/package_bundle_reader_test.dart
@@ -153,8 +153,8 @@ class ResynthesizerResultProviderTest {
@reflectiveTest
class SummaryDataStoreTest {
- SummaryDataStore dataStore = new SummaryDataStore(<String>[],
- recordDependencyInfo: true, disallowOverlappingSummaries: true);
+ SummaryDataStore dataStore =
+ new SummaryDataStore(<String>[], disallowOverlappingSummaries: true);
PackageBundle bundle1 = new _PackageBundleMock();
PackageBundle bundle2 = new _PackageBundleMock();
@@ -170,16 +170,6 @@ class SummaryDataStoreTest {
test_addBundle() {
expect(dataStore.bundles, unorderedEquals([bundle1, bundle2]));
- expect(dataStore.dependencies[0].summaryPath, '/p1.ds');
- expect(dataStore.dependencies[0].apiSignature, 'signature1');
- expect(dataStore.dependencies[0].includedPackageNames, ['p1']);
- expect(dataStore.dependencies[0].includesFileUris, false);
- expect(dataStore.dependencies[0].includesDartUris, false);
- expect(dataStore.dependencies[1].summaryPath, '/p2.ds');
- expect(dataStore.dependencies[1].apiSignature, 'signature2');
- expect(dataStore.dependencies[1].includedPackageNames, ['p2']);
- expect(dataStore.dependencies[1].includesFileUris, false);
- expect(dataStore.dependencies[1].includesDartUris, false);
expect(dataStore.uriToSummaryPath,
containsPair('package:p1/u1.dart', '/p1.ds'));
// unlinkedMap
@@ -206,9 +196,6 @@ class SummaryDataStoreTest {
when(bundle.linkedLibraries).thenReturn(<LinkedLibrary>[linkedLibrary1]);
when(bundle.apiSignature).thenReturn('signature');
dataStore.addBundle('/p3.ds', bundle);
- expect(dataStore.dependencies.last.includedPackageNames, []);
- expect(dataStore.dependencies.last.includesFileUris, false);
- expect(dataStore.dependencies.last.includesDartUris, true);
}
test_addBundle_fileUris() {
@@ -219,9 +206,6 @@ class SummaryDataStoreTest {
when(bundle.linkedLibraries).thenReturn(<LinkedLibrary>[linkedLibrary1]);
when(bundle.apiSignature).thenReturn('signature');
dataStore.addBundle('/p3.ds', bundle);
- expect(dataStore.dependencies.last.includedPackageNames, []);
- expect(dataStore.dependencies.last.includesFileUris, true);
- expect(dataStore.dependencies.last.includesDartUris, false);
}
test_addBundle_multiProject() {
@@ -238,12 +222,11 @@ class SummaryDataStoreTest {
// p3 conflicts (overlaps) with existing summaries.
expect(() => dataStore.addBundle('/p3.ds', bundle),
throwsA(isConflictingSummaryException));
- expect(dataStore.dependencies.last.includedPackageNames, ['p1', 'p2']);
}
test_addBundle_multiProjectOverlap() {
- SummaryDataStore dataStore2 = new SummaryDataStore(<String>[],
- recordDependencyInfo: true, disallowOverlappingSummaries: false);
+ SummaryDataStore dataStore2 =
+ new SummaryDataStore(<String>[], disallowOverlappingSummaries: false);
_setupDataStore(dataStore2);
PackageBundle bundle = new _PackageBundleMock();
@@ -258,7 +241,6 @@ class SummaryDataStoreTest {
when(bundle.apiSignature).thenReturn('signature');
// p3 conflicts (overlaps) with existing summaries, but now allowed.
dataStore2.addBundle('/p3.ds', bundle);
- expect(dataStore2.dependencies.last.includedPackageNames, ['p1', 'p2']);
}
test_getContainingLibraryUris_libraryUri() {
« no previous file with comments | « pkg/analyzer/test/src/summary/linker_test.dart ('k') | pkg/analyzer/test/src/summary/summarize_ast_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698