Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: pkg/analyzer/lib/src/summary/package_bundle_reader.dart

Issue 2996783002: Don't record dependencies in SummaryDataStore. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/package_bundle_reader.dart
diff --git a/pkg/analyzer/lib/src/summary/package_bundle_reader.dart b/pkg/analyzer/lib/src/summary/package_bundle_reader.dart
index 9e8c7d680d1b8b5d3a0f46cca35624e986d4f08c..c58671755b0018217c98c75618c6254b58fbb160 100644
--- a/pkg/analyzer/lib/src/summary/package_bundle_reader.dart
+++ b/pkg/analyzer/lib/src/summary/package_bundle_reader.dart
@@ -11,7 +11,6 @@ import 'package:analyzer/src/generated/resolver.dart' show TypeProvider;
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/source_io.dart';
import 'package:analyzer/src/generated/utilities_dart.dart';
-import 'package:analyzer/src/summary/format.dart';
import 'package:analyzer/src/summary/idl.dart';
import 'package:analyzer/src/summary/resynthesize.dart';
import 'package:analyzer/src/task/dart.dart';
@@ -368,15 +367,6 @@ class SummaryDataStore {
*/
final List<PackageBundle> bundles = <PackageBundle>[];
- /**
- * List of dependency information for the package bundles in this
- * [SummaryDataStore], in a form that is ready to store in a newly generated
- * summary. Computing this information has nonzero cost, so it is only
- * recorded if the [SummaryDataStore] is constructed with the argument
- * `recordDependencies`. Otherwise `null`.
- */
- final List<PackageDependencyInfoBuilder> dependencies;
-
/**
* Map from the URI of a compilation unit to the unlinked summary of that
* compilation unit.
@@ -405,18 +395,13 @@ class SummaryDataStore {
/**
* Create a [SummaryDataStore] and populate it with the summaries in
- * [summaryPaths]. If [recordDependencyInfo] is `true`, record
- * [PackageDependencyInfo] for each summary, for later access via
- * [dependencies].
+ * [summaryPaths].
*/
SummaryDataStore(Iterable<String> summaryPaths,
- {bool recordDependencyInfo: false,
- bool disallowOverlappingSummaries: false,
+ {bool disallowOverlappingSummaries: false,
ResourceProvider resourceProvider})
: _summaryPaths = summaryPaths,
- _disallowOverlappingSummaries = disallowOverlappingSummaries,
- dependencies =
- recordDependencyInfo ? <PackageDependencyInfoBuilder>[] : null {
+ _disallowOverlappingSummaries = disallowOverlappingSummaries {
summaryPaths.forEach((String path) => _fillMaps(path, resourceProvider));
}
@@ -425,29 +410,6 @@ class SummaryDataStore {
*/
void addBundle(String path, PackageBundle bundle) {
bundles.add(bundle);
- if (dependencies != null) {
- Set<String> includedPackageNames = new Set<String>();
- bool includesDartUris = false;
- bool includesFileUris = false;
- for (String uriString in bundle.unlinkedUnitUris) {
- Uri uri = Uri.parse(uriString);
- String scheme = uri.scheme;
- if (scheme == 'package') {
- List<String> pathSegments = uri.pathSegments;
- includedPackageNames.add(pathSegments.isEmpty ? '' : pathSegments[0]);
- } else if (scheme == 'file') {
- includesFileUris = true;
- } else if (scheme == 'dart') {
- includesDartUris = true;
- }
- }
- dependencies.add(new PackageDependencyInfoBuilder(
- includedPackageNames: includedPackageNames.toList()..sort(),
- includesDartUris: includesDartUris,
- includesFileUris: includesFileUris,
- apiSignature: bundle.apiSignature,
- summaryPath: path));
- }
for (int i = 0; i < bundle.unlinkedUnitUris.length; i++) {
String uri = bundle.unlinkedUnitUris[i];
if (_disallowOverlappingSummaries &&
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698