Don't record dependencies in SummaryDataStore.

pkg/analyzer/lib/src/summary/package_bundle_reader.dart

 import 'dart:io' as io;
 import 'dart:math' show min;
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/context/context.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/resolver.dart' show TypeProvider;
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:analyzer/src/generated/utilities_dart.dart';
-import 'package:analyzer/src/summary/format.dart';
 import 'package:analyzer/src/summary/idl.dart';
 import 'package:analyzer/src/summary/resynthesize.dart';
 import 'package:analyzer/src/task/dart.dart';
 import 'package:analyzer/task/dart.dart';
 import 'package:analyzer/task/general.dart';
 import 'package:analyzer/task/model.dart';
 import 'package:front_end/src/base/source.dart';
 
 /**
  * A [ConflictingSummaryException] indicates that two different summaries
@@ skipping 337 matching lines @@
  * summary package bundles.  It contains maps which can be used to find linked
  * and unlinked summaries by URI.
  */
 class SummaryDataStore {
   /**
    * List of all [PackageBundle]s.
    */
   final List<PackageBundle> bundles = <PackageBundle>[];
 
   /**
-   * List of dependency information for the package bundles in this
-   * [SummaryDataStore], in a form that is ready to store in a newly generated
-   * summary.  Computing this information has nonzero cost, so it is only
-   * recorded if the [SummaryDataStore] is constructed with the argument
-   * `recordDependencies`.  Otherwise `null`.
-   */
-  final List<PackageDependencyInfoBuilder> dependencies;
-
-  /**
    * Map from the URI of a compilation unit to the unlinked summary of that
    * compilation unit.
    */
   final Map<String, UnlinkedUnit> unlinkedMap = <String, UnlinkedUnit>{};
 
   /**
    * Map from the URI of a library to the linked summary of that library.
    */
   final Map<String, LinkedLibrary> linkedMap = <String, LinkedLibrary>{};
 
   /**
    * Map from the URI of a library to the summary path that contained it.
    */
   final Map<String, String> uriToSummaryPath = <String, String>{};
 
   /**
    * List of summary paths.
    */
   final Iterable<String> _summaryPaths;
 
   /**
    * If true, do not accept multiple summaries that contain the same Dart uri.
    */
   bool _disallowOverlappingSummaries;
 
   /**
    * Create a [SummaryDataStore] and populate it with the summaries in
-   * [summaryPaths].  If [recordDependencyInfo] is `true`, record
-   * [PackageDependencyInfo] for each summary, for later access via
-   * [dependencies].
+   * [summaryPaths].
    */
   SummaryDataStore(Iterable<String> summaryPaths,
-      {bool recordDependencyInfo: false,
-      bool disallowOverlappingSummaries: false,
+      {bool disallowOverlappingSummaries: false,
       ResourceProvider resourceProvider})
       : _summaryPaths = summaryPaths,
-        _disallowOverlappingSummaries = disallowOverlappingSummaries,
-        dependencies =
-            recordDependencyInfo ? <PackageDependencyInfoBuilder>[] : null {
+        _disallowOverlappingSummaries = disallowOverlappingSummaries {
     summaryPaths.forEach((String path) => _fillMaps(path, resourceProvider));
   }
 
   /**
    * Add the given [bundle] loaded from the file with the given [path].
    */
   void addBundle(String path, PackageBundle bundle) {
     bundles.add(bundle);
-    if (dependencies != null) {
-      Set<String> includedPackageNames = new Set<String>();
-      bool includesDartUris = false;
-      bool includesFileUris = false;
-      for (String uriString in bundle.unlinkedUnitUris) {
-        Uri uri = Uri.parse(uriString);
-        String scheme = uri.scheme;
-        if (scheme == 'package') {
-          List<String> pathSegments = uri.pathSegments;
-          includedPackageNames.add(pathSegments.isEmpty ? '' : pathSegments[0]);
-        } else if (scheme == 'file') {
-          includesFileUris = true;
-        } else if (scheme == 'dart') {
-          includesDartUris = true;
-        }
-      }
-      dependencies.add(new PackageDependencyInfoBuilder(
-          includedPackageNames: includedPackageNames.toList()..sort(),
-          includesDartUris: includesDartUris,
-          includesFileUris: includesFileUris,
-          apiSignature: bundle.apiSignature,
-          summaryPath: path));
-    }
     for (int i = 0; i < bundle.unlinkedUnitUris.length; i++) {
       String uri = bundle.unlinkedUnitUris[i];
       if (_disallowOverlappingSummaries &&
           uriToSummaryPath.containsKey(uri) &&
           (uriToSummaryPath[uri] != path)) {
         throw new ConflictingSummaryException(
             _summaryPaths, uri, uriToSummaryPath[uri], path);
       }
       uriToSummaryPath[uri] = path;
       addUnlinkedUnit(uri, bundle.unlinkedUnits[i]);
@@ skipping 65 matching lines @@
       var file = resourceProvider.getFile(path);
       buffer = file.readAsBytesSync();
     } else {
       io.File file = new io.File(path);
       buffer = file.readAsBytesSync();
     }
     PackageBundle bundle = new PackageBundle.fromBuffer(buffer);
     addBundle(path, bundle);
   }
 }