Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2995763002: Reland of ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict (Closed)

Created:
3 years, 4 months ago by agrieve
Modified:
3 years, 4 months ago
Reviewers:
jbudorick
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Reland of ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict Reverted in: https://codereview.chromium.org/3000783002/ Reason for reland: Fixed export check. According to docs (and reality), activities are exported by default if they contain any intent filters. BUG=chromium:749239 Review-Url: https://codereview.chromium.org/2995763002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/36df457355af707fb882dbe79e1e65dc6c097112

Patch Set 1 #

Patch Set 2 : fix exported check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -28 lines) Patch
M devil/devil/android/apk_helper.py View 1 5 chunks +60 lines, -15 lines 0 comments Download
M devil/devil/android/apk_helper_test.py View 1 5 chunks +43 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
agrieve
Created Reland of ApkHelper: Add GetViewActivityName(). Make GetActivityName() more strict
3 years, 4 months ago (2017-08-11 14:55:34 UTC) #1
agrieve
On 2017/08/11 14:55:34, agrieve wrote: > Created Reland of ApkHelper: Add GetViewActivityName(). Make GetActivityName() > ...
3 years, 4 months ago (2017-08-11 16:01:51 UTC) #7
jbudorick
lgtm
3 years, 4 months ago (2017-08-11 16:23:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2995763002/70001
3 years, 4 months ago (2017-08-11 17:49:05 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-11 17:50:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698